Fix 01926_order_by_desc_limit test for 1MB HTTP buffers#65466
Merged
Algunenano merged 1 commit intomasterfrom Jun 20, 2024
Merged
Fix 01926_order_by_desc_limit test for 1MB HTTP buffers#65466Algunenano merged 1 commit intomasterfrom
01926_order_by_desc_limit test for 1MB HTTP buffers#65466Algunenano merged 1 commit intomasterfrom
Conversation
Contributor
|
This is an automated comment for commit fc8c103 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was broken after #65028
Report: https://s3.amazonaws.com/clickhouse-test-reports/0/ef34ec874a9e7e3cf1ac51a92a81ed46e5f1d1ed/stateless_tests__debug__s3_storage__%5B3_6%5D.html
The thing is this test uses 100 partitions so query does 200 S3 requests in total using multiple threads, and every thread uses 1MB buffers now. So now peek memory consumption of these two queries are ~400MB and ~500MB. More detailed diagnostics is here
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
This change was reverted
Documentation entry for user-facing changes
CI Settings (Only check the boxes if you know what you are doing):
Closes #65472