Skip to content

Backport #65198 to 23.8: Fix a bug in ClickHouse Keeper that causes digest mismatch during closing session#65368

Merged
antonio2368 merged 2 commits into23.8from
backport/23.8/65198
Jun 24, 2024
Merged

Backport #65198 to 23.8: Fix a bug in ClickHouse Keeper that causes digest mismatch during closing session#65368
antonio2368 merged 2 commits into23.8from
backport/23.8/65198

Conversation

@robot-ch-test-poll4
Copy link
Copy Markdown
Contributor

@robot-ch-test-poll4 robot-ch-test-poll4 commented Jun 18, 2024

Original pull-request #65198
Cherry-pick pull-request #65367

This pull-request is a last step of an automated backporting.
Treat it as a standard pull-request: look at the checks and resolve conflicts.
Merge it only if you intend to backport changes to the target branch, otherwise just close it.

@robot-ch-test-poll4 robot-ch-test-poll4 added pr-backport Changes, backported to release branch. Do not use manually - automated use only! pr-critical-bugfix labels Jun 18, 2024
@robot-ch-test-poll3
Copy link
Copy Markdown
Contributor

robot-ch-test-poll3 commented Jun 18, 2024 •
edited by robot-clickhouse-ci-2
Loading

This is an automated comment for commit 6031b81 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure

aalexfvk
aalexfvk reviewed Jun 19, 2024
View reviewed changes
@aalexfvk
Copy link
Copy Markdown
Contributor

aalexfvk commented Jun 24, 2024 •
edited
Loading

There are a bit fails. It seems not relevant. And looking on other backport PRs.

@antonio2368 antonio2368 merged commit 84a28c6 into 23.8 Jun 24, 2024
@antonio2368 antonio2368 deleted the backport/23.8/65198 branch June 24, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonio2368 antonio2368 antonio2368 left review comments

+1 more reviewer

@aalexfvk aalexfvk aalexfvk left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@antonio2368 antonio2368

Labels

pr-backport Changes, backported to release branch. Do not use manually - automated use only! pr-critical-bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@robot-ch-test-poll4 @robot-ch-test-poll3 @aalexfvk @antonio2368 @robot-clickhouse