Skip to content

Aggregate function groupConcat (#63671)#65009

Merged
Avogar merged 3 commits intoClickHouse:masterfrom
yariks5s:group_concat
Jun 17, 2024
Merged

Aggregate function groupConcat (#63671)#65009
Avogar merged 3 commits intoClickHouse:masterfrom
yariks5s:group_concat

Conversation

@yariks5s
Copy link
Copy Markdown
Member

@yariks5s yariks5s commented Jun 7, 2024 •
edited by Algunenano
Loading

REVERTED

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

REVERTED

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All NOT Required Checks
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: Integration Tests
  • Exclude: Stateless tests
  • Exclude: Stateful tests
  • Exclude: Performance tests
  • Exclude: All with ASAN
  • Exclude: All with Aarch64
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Do not test
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-feature Pull request with new product feature label Jun 7, 2024
@robot-clickhouse-ci-1
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-1 commented Jun 7, 2024 •
edited by robot-clickhouse
Loading

This is an automated comment for commit 108f3f9 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR❌ failure
Mergeable CheckChecks if all other necessary checks are successful❌ failure
PR CheckChecks correctness of the PR's body❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
A SyncIf it fails, ask a maintainer for help✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success

@jsc0218 jsc0218 self-assigned this Jun 11, 2024
@jsc0218
Copy link
Copy Markdown
Contributor

jsc0218 commented Jun 14, 2024

might update with the master once, the test failure should irrelevant.

@Avogar Avogar added this pull request to the merge queue Jun 17, 2024
Merged via the queue into ClickHouse:master with commit fb50f94 Jun 17, 2024
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jun 17, 2024
@yariks5s yariks5s mentioned this pull request Jun 18, 2024
Closed
31 tasks
@CheSema CheSema mentioned this pull request Jun 18, 2024
Merged
30 tasks
CheSema
CheSema reviewed Jun 18, 2024
View reviewed changes
src/AggregateFunctions/AggregateFunctionGroupConcat.cpp
writeVarUInt(cur_data.data_size, buf);
writeVarUInt(cur_data.allocated_size, buf);

buf.write(cur_data.data, cur_data.data_size);
Copy link
Copy Markdown
Member

@CheSema CheSema Jun 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the memory is not allocated yet here.
This is an example of SigFault https://s3.amazonaws.com/clickhouse-test-reports/64478/517c1138113220e5a4318c07806759911896234d/stress_test__debug_.html

@Algunenano Algunenano added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jun 20, 2024
Algunenano added a commit to Algunenano/ClickHouse that referenced this pull request Jun 20, 2024
@Algunenano
Revert "Merge pull request ClickHouse#65009 from yariks5s/group_concat"
bbd7e31 
This reverts commit fb50f94, reversing
changes made to 9894383.
@Algunenano Algunenano mentioned this pull request Jun 20, 2024
Merged
@Jasmine-ge Jasmine-ge mentioned this pull request Feb 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CheSema CheSema CheSema left review comments

+1 more reviewer

@jsc0218 jsc0218 jsc0218 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jsc0218 jsc0218

Labels

pr-feature Pull request with new product feature pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yariks5s @robot-clickhouse-ci-1 @jsc0218 @CheSema @Algunenano @Avogar