Skip to content

ExpressionAnalyzer and ActionsVisitor refactoring#6499

Merged
alexey-milovidov merged 5 commits intoClickHouse:masterfrom
4ertus2:refactoring
Aug 15, 2019
Merged

ExpressionAnalyzer and ActionsVisitor refactoring#6499
alexey-milovidov merged 5 commits intoClickHouse:masterfrom
4ertus2:refactoring

Conversation

@4ertus2
Copy link
Copy Markdown
Contributor

@4ertus2 4ertus2 commented Aug 14, 2019

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Category (leave one):

  • Improvement

Short description (up to few sentences):
Extract SelectQueryExpressionAnalyzer from ExpressionAnalyzer. Keep the last one for non-select queries.

@4ertus2 4ertus2 added the do not test disable testing on pull request label Aug 15, 2019
@4ertus2 4ertus2 removed the do not test disable testing on pull request label Aug 15, 2019
@4ertus2 4ertus2 changed the title Refactoring: extract SelectQueryExpressionAnalyzer ExpressionAnalyzer and ActionsVisitor refactoring Aug 15, 2019
@alexey-milovidov alexey-milovidov merged commit bd2c5e1 into ClickHouse:master Aug 15, 2019
@KochetovNicolai KochetovNicolai added the pr-improvement Pull request with some product improvements label Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-improvement Pull request with some product improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants