Skip to content

Fix 02444_async_broken_outdated_part_loading flakiness#64956

Merged
pufit merged 1 commit intoClickHouse:masterfrom
azat:tests/02444_async_broken_outdated_part_loading
Jul 29, 2024
Merged

Fix 02444_async_broken_outdated_part_loading flakiness#64956
pufit merged 1 commit intoClickHouse:masterfrom
azat:tests/02444_async_broken_outdated_part_loading

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Jun 7, 2024

It uses already removed path to detect the absolute path:

2024.06.06 22:36:55.845743 [ 1055 ] {} <Debug> test_858tcd7j.rmt (8d64bafa-bedf-4015-9673-8911de129a8f): Removing 2 parts from memory: Parts: [all_0_0_0, all_1_1_0]
2024.06.06 22:36:56.608589 [ 2065 ] {41c3a91d-2ee5-4006-bb79-92e7e8f005bb} <Debug> executeQuery: (from [::1]:48792) (comment: 02444_async_broken_outdated_part_loading.sh) select path from system.parts where database='test_858tcd7j' and table='rmt' and name='all_1_1_0' (stage: Complete)

CI: https://s3.amazonaws.com/clickhouse-test-reports/64856/d10027cc3b7737c524f4cfce262d46753fd03036/stateless_tests__debug__[5_5].html

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: Stateless tests

@robot-ch-test-poll2
Copy link
Copy Markdown
Contributor

robot-ch-test-poll2 commented Jun 7, 2024

This is an automated comment for commit e8c95bb with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success

@pufit pufit self-assigned this Jun 7, 2024
@azat azat force-pushed the tests/02444_async_broken_outdated_part_loading branch from 94a5f17 to 8b77367 Compare June 15, 2024 14:57
@azat
Copy link
Copy Markdown
Member Author

azat commented Jul 5, 2024

@pufit does it waits something from my side?

@azat
Copy link
Copy Markdown
Member Author

azat commented Jul 25, 2024

@pufit kind ping

@pufit
Copy link
Copy Markdown
Member

pufit commented Jul 26, 2024

@pufit kind ping

I'm sorry I missed the last ping. Can you merge master to this branch once more?

It uses already removed path to detect the absolute path:

    2024.06.06 22:36:55.845743 [ 1055 ] {} <Debug> test_858tcd7j.rmt (8d64bafa-bedf-4015-9673-8911de129a8f): Removing 2 parts from memory: Parts: [all_0_0_0, all_1_1_0]
    2024.06.06 22:36:56.608589 [ 2065 ] {41c3a91d-2ee5-4006-bb79-92e7e8f005bb} <Debug> executeQuery: (from [::1]:48792) (comment: 02444_async_broken_outdated_part_loading.sh) select path from system.parts where database='test_858tcd7j' and table='rmt' and name='all_1_1_0' (stage: Complete)

CI: https://s3.amazonaws.com/clickhouse-test-reports/64856/d10027cc3b7737c524f4cfce262d46753fd03036/stateless_tests__debug__[5_5].html
Signed-off-by: Azat Khuzhin <[email protected]>
@azat azat force-pushed the tests/02444_async_broken_outdated_part_loading branch from 8b77367 to e8c95bb Compare July 29, 2024 04:59
@azat
Copy link
Copy Markdown
Member Author

azat commented Jul 29, 2024

@pufit done

@pufit pufit added this pull request to the merge queue Jul 29, 2024
Merged via the queue into ClickHouse:master with commit ef51c94 Jul 29, 2024
@azat azat deleted the tests/02444_async_broken_outdated_part_loading branch July 29, 2024 18:52
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants