Skip to content

Fix 03002_part_log_rmt_fetch_mutate_error flakiness#64887

Closed
azat wants to merge 1 commit intoClickHouse:masterfrom
azat:tests/03002_part_log_rmt_fetch_mutate_error
Closed

Fix 03002_part_log_rmt_fetch_mutate_error flakiness#64887
azat wants to merge 1 commit intoClickHouse:masterfrom
azat:tests/03002_part_log_rmt_fetch_mutate_error

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Jun 6, 2024 •
edited
Loading

CI: https://s3.amazonaws.com/clickhouse-test-reports/61973/6cfd5b2165970a65a551117fe58e4b9d22237b8c/stateless_tests__debug__s3_storage__[3_6].html

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: Stateless tests

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jun 6, 2024
@robot-clickhouse-ci-1
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-1 commented Jun 6, 2024 •
edited by robot-ch-test-poll2
Loading

This is an automated comment for commit 8b4bfed with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR❌ failure
Mergeable CheckChecks if all other necessary checks are successful❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
A SyncIf it fails, ask a maintainer for help✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
PR CheckChecks correctness of the PR's body✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success

@azat azat mentioned this pull request Jun 6, 2024
Merged
@azat
Copy link
Copy Markdown
Member Author

azat commented Jun 6, 2024

Integration tests (asan, old analyzer) [2/6] — fail: 1, passed: 393

@azat azat mentioned this pull request Jun 6, 2024
Merged
31 tasks
@alesapin alesapin enabled auto-merge June 6, 2024 09:56
@alesapin alesapin self-assigned this Jun 6, 2024
auto-merge was automatically disabled June 6, 2024 12:59

Head branch was pushed to by a user without write access

@azat azat force-pushed the tests/03002_part_log_rmt_fetch_mutate_error branch from 5d01a2f to a1e3605 Compare June 6, 2024 12:59
@azat
Copy link
Copy Markdown
Member Author

azat commented Jun 6, 2024

Note, that I've added CI settings for this PR, to run only stateless tests

@azat
Copy link
Copy Markdown
Member Author

azat commented Jun 6, 2024 •
edited
Loading

Stateless tests (release) — fail: 1, passed: 6632, skipped: 13

Stateless tests flaky check (asan) — fail: 0, passed: 92

Passed

@azat azat force-pushed the tests/03002_part_log_rmt_fetch_mutate_error branch from a1e3605 to 8b4bfed Compare June 15, 2024 14:57
@azat
Copy link
Copy Markdown
Member Author

azat commented Jul 5, 2024

@alesapin does it waits something from my side?

@azat
Copy link
Copy Markdown
Member Author

azat commented Jul 25, 2024 •
edited
Loading

@alexey-milovidov that is sad that instead of merging this PR the test was completely removed - #66823

Closed in favor of #67113

Upd: there is also similar change - #65720, yes it does not helps to make the test non flaky, but still

@azat azat closed this Jul 25, 2024
@azat azat deleted the tests/03002_part_log_rmt_fetch_mutate_error branch July 25, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alesapin alesapin alesapin approved these changes

Assignees

@alesapin alesapin

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@azat @robot-clickhouse-ci-1 @alesapin