Skip to content

build fix#6486

Merged
vitlibar merged 1 commit intoClickHouse:masterfrom
Vxider:master
Aug 16, 2019
Merged

build fix#6486
vitlibar merged 1 commit intoClickHouse:masterfrom
Vxider:master

Conversation

@Vxider
Copy link
Copy Markdown
Contributor

@Vxider Vxider commented Aug 14, 2019

@alexey-milovidov
Copy link
Copy Markdown
Member

What exactly does it fix?

@alexey-milovidov alexey-milovidov added the st-need-info We need extra data to continue (waiting for response). Either some details or a repro of the issue. label Aug 14, 2019
@Vxider
Copy link
Copy Markdown
Contributor Author

Vxider commented Aug 15, 2019

build fails when trying to use SettingsChanges::changes() due to ctor deduction failure

@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Aug 15, 2019

What build (what OS, compiler, version, additional options) and what message do you get?

We have build check in CI and all supported builds have passed: https://clickhouse-builds.s3.yandex.net/6509/c52a34fd15bc834ab40c8ef91ee281a89d58e2b3/report.html

@Vxider
Copy link
Copy Markdown
Contributor Author

Vxider commented Aug 16, 2019

The build check is passed because this function is not called in ClickHouse. Build the following example with g++-8 will encounter the error.

#include <iostream>
#include <vector>

using namespace std;

using String = std::string;

struct SettingChange {
    String name;
    int value;
};

using SettingsChanges = std::vector<SettingChange>;

int main() {
    String name= "test";
    int value = 0;
    SettingsChanges found_changes;
    found_changes.emplace_back(name, value);
    return 0;
}

Error:

/usr/local/Cellar/gcc@8/8.3.0/include/c++/8.3.0/ext/new_allocator.h:136:4: error: no matching function for call to 'SettingChange::SettingChange(std::__cxx11::basic_string<char>&, int&)'
  { ::new((void *)__p) _Up(std::forward<_Args>(__args)...); }
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test.cpp:8:8: note: candidate: 'SettingChange::SettingChange()'

@vitlibar vitlibar merged commit fa5f802 into ClickHouse:master Aug 16, 2019
@alexey-milovidov
Copy link
Copy Markdown
Member

Thank you!

@KochetovNicolai KochetovNicolai added pr-bugfix Pull request with bugfix, not backported by default pr-build Pull request with build/testing/packaging improvement and removed pr-bugfix Pull request with bugfix, not backported by default labels Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-build Pull request with build/testing/packaging improvement st-need-info We need extra data to continue (waiting for response). Either some details or a repro of the issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants