Skip to content

Handle logs from rocksdb by ClickHouse internal logging (and enable debug rocksdb logging on CI)#64856

Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
azat:rocksdb-logging
Jun 7, 2024
Merged

Handle logs from rocksdb by ClickHouse internal logging (and enable debug rocksdb logging on CI)#64856
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
azat:rocksdb-logging

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Jun 5, 2024

Someone may not know about /path/to/rocksdb/LOG, and besides it requires an access to data dir, instead of logs dir.

And enable debug rocksdb logging on CI, to understand the root cause of 02956_rocksdb_bulk_sink failures 1 (likely due to some merge had been done in background I guess)

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Handle logs from rocksdb by ClickHouse internal logging

Cc: @canhld94

@azat azat mentioned this pull request Jun 5, 2024
Merged
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jun 5, 2024
@robot-clickhouse-ci-1
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-1 commented Jun 5, 2024 •
edited
Loading

This is an automated comment for commit d10027c with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
A SyncIf it fails, ask a maintainer for help⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Mergeable CheckChecks if all other necessary checks are successful⏳ pending
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
PR CheckChecks correctness of the PR's body✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@alexey-milovidov alexey-milovidov self-assigned this Jun 5, 2024
@azat azat marked this pull request as draft June 5, 2024 18:25
@azat azat force-pushed the rocksdb-logging branch from 8cefc1a to 7ec2fc0 Compare June 6, 2024 13:06
@azat azat marked this pull request as ready for review June 6, 2024 13:06
azat added 2 commits June 6, 2024 17:47
@azat
Handle logs from rocksdb by ClickHouse internal logging
833f031 
Someone may not know about /path/to/rocksdb/LOG, and besides it requires
an access to data dir, instead of logs dir.

v2: fix use-after-free due to destruction order (https://s3.amazonaws.com/clickhouse-test-reports/64856/8cefc1a1ba5ddfdda033694a14e1f1847d497092/stateless_tests__asan__[2_4]/stderr.log)

Signed-off-by: Azat Khuzhin <[email protected]>
@azat
Enable debug logging for rocksdb on CI
d10027c 
To understand the root cause of 02956_rocksdb_bulk_sink failures, this
is likely due to some background merge had been done I would say, but it
is hard to say without extra information.

Signed-off-by: Azat Khuzhin <[email protected]>
@azat azat force-pushed the rocksdb-logging branch from 7ec2fc0 to d10027c Compare June 6, 2024 15:47
@azat
Copy link
Copy Markdown
Member Author

azat commented Jun 7, 2024

Test failures does not related:

Integration tests (aarch64) [5/6] — fail: 1, passed: 582

Stateless tests (debug) [5/5] — fail: 1, passed: 1333, skipped: 12

@alexey-milovidov alexey-milovidov merged commit c33b39f into ClickHouse:master Jun 7, 2024
@Algunenano Algunenano mentioned this pull request Jun 7, 2024
Closed
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Jun 7, 2024
@azat azat deleted the rocksdb-logging branch June 8, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@azat @robot-clickhouse-ci-1 @alexey-milovidov @robot-clickhouse