Skip to content

Simplify handling of old 'inverted' indexes#64846

Merged
nikitamikhaylov merged 1 commit intoClickHouse:masterfrom
rschu1ze:simplify-inverted-indexes
Jun 5, 2024
Merged

Simplify handling of old 'inverted' indexes#64846
nikitamikhaylov merged 1 commit intoClickHouse:masterfrom
rschu1ze:simplify-inverted-indexes

Conversation

@rschu1ze
Copy link
Copy Markdown
Member

@rschu1ze rschu1ze commented Jun 5, 2024 •
edited
Loading

This is follow-up to #64656.

The earlier PR added a "backdoor" (for the lack of a better word) to enable the load of old inverted-type indexes. The backdoor requires setting allow_experimental_inverted_index to be 0. Chances are that this setting was set in the server configuration as 1, meaning that the backdoor will not cover the load of tables at system startup.

With this PR, things are simplified: Tables with old inverted indexes can now always be loaded at startup, assuming that allow_experimental_inverted_index is 1. To encourage a migration to full_text indexes, an exception is thrown when inverted indexes are used (this did not change compared to #64656).

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jun 5, 2024
@robot-ch-test-poll1
Copy link
Copy Markdown
Contributor

robot-ch-test-poll1 commented Jun 5, 2024 •
edited by robot-ch-test-poll3
Loading

This is an automated comment for commit 8bdd291 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR❌ failure
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure
Successful checks
Check nameDescriptionStatus
A SyncIf it fails, ask a maintainer for help✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckChecks correctness of the PR's body✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success

@nikitamikhaylov
Copy link
Copy Markdown
Member

nikitamikhaylov commented Jun 5, 2024

Upgrade check - #64860

@nikitamikhaylov nikitamikhaylov self-assigned this Jun 5, 2024
@nikitamikhaylov nikitamikhaylov added this pull request to the merge queue Jun 5, 2024
Merged via the queue into ClickHouse:master with commit efbf40a Jun 5, 2024
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jun 5, 2024
@robot-clickhouse robot-clickhouse added the pr-backports-created-cloud deprecated label, NOOP label Jun 5, 2024
@rschu1ze rschu1ze mentioned this pull request Jun 6, 2024
Merged
@Felixoid Felixoid removed the pr-backports-created-cloud deprecated label, NOOP label Jun 7, 2024
@robot-ch-test-poll robot-ch-test-poll added the pr-backports-created-cloud deprecated label, NOOP label Jun 8, 2024
rschu1ze added a commit to rschu1ze/ClickHouse that referenced this pull request Jun 10, 2024
@rschu1ze
Add migration helper for legacy 'annoy' and 'usearch' indexes types
eaa888f 
Index types 'annoy' and 'usearch' were removed and replaced by
'vector_similarity' indexes in an earlier commit.

This means unfortuantely, that if customers have tables with these
indexes and upgrade, their database might not start anymore - the
system loads the metadata at startup, thinks something is wrong with
such tables, and halts immediately.

This commit adds support for loading and attaching such indexes back.
Data insert or use (search) return an error which recommends a migration
to 'vector_similarity' indexes. The implementation is generally similar
to what has recently been implemented for 'full_text' indexes [1, 2].

[1] ClickHouse#64656
[2] ClickHouse#64846
rschu1ze added a commit to rschu1ze/ClickHouse that referenced this pull request Aug 12, 2024
@rschu1ze
Add migration helper for legacy 'annoy' and 'usearch' indexes types
cc5c64e 
Index types 'annoy' and 'usearch' were removed and replaced by
'vector_similarity' indexes in an earlier commit.

This means unfortuantely, that if customers have tables with these
indexes and upgrade, their database might not start anymore - the
system loads the metadata at startup, thinks something is wrong with
such tables, and halts immediately.

This commit adds support for loading and attaching such indexes back.
Data insert or use (search) return an error which recommends a migration
to 'vector_similarity' indexes. The implementation is generally similar
to what has recently been implemented for 'full_text' indexes [1, 2].

[1] ClickHouse#64656
[2] ClickHouse#64846
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikitamikhaylov nikitamikhaylov nikitamikhaylov approved these changes

Assignees

@nikitamikhaylov nikitamikhaylov

Labels

pr-backports-created-cloud deprecated label, NOOP pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rschu1ze @robot-ch-test-poll1 @nikitamikhaylov @Felixoid @robot-clickhouse @robot-ch-test-poll