Skip to content

Follow-up to #64349#64845

Merged
alexey-milovidov merged 3 commits intomasterfrom
follow-up-s3-queue
Jun 6, 2024
Merged

Follow-up to #64349#64845
alexey-milovidov merged 3 commits intomasterfrom
follow-up-s3-queue

Conversation

@kssenii
Copy link
Copy Markdown
Member

@kssenii kssenii commented Jun 5, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Follow up to #64349.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Builds
  • Allow: Performance tests
  • Allow: All NOT Required Checks
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs

  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: Integration Tests
  • Exclude: Stateless tests
  • Exclude: Stateful tests
  • Exclude: Performance tests
  • Exclude: All with ASAN
  • Exclude: All with Aarch64
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage

  • Do not test
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jun 5, 2024
@robot-ch-test-poll1
Copy link
Copy Markdown
Contributor

robot-ch-test-poll1 commented Jun 5, 2024

This is an automated comment for commit 5ec3699 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
A SyncIf it fails, ask a maintainer for help⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Mergeable CheckChecks if all other necessary checks are successful⏳ pending
Successful checks
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
PR CheckChecks correctness of the PR's body✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success

@alexey-milovidov alexey-milovidov self-assigned this Jun 5, 2024
@alexey-milovidov alexey-milovidov merged commit 9ab0693 into master Jun 6, 2024
@alexey-milovidov alexey-milovidov deleted the follow-up-s3-queue branch June 6, 2024 00:56
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jun 6, 2024
@azat
Copy link
Copy Markdown
Member

azat commented Jun 6, 2024

This had been merged with test failures (test_mask_sensitive_info/test.py::test_create_table), and due to "CI re-design" (#64093 (comment)) CI is "broken", i.e. it does not pass further to other stages, and this will not allow to merge anything I guess (and will lead to tons of rebases/merges with master)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants