Skip to content

Fix clang-tidy#64827

Merged
hanfei1991 merged 2 commits intomasterfrom
fix-clang-tidy-s3-queue
Jun 5, 2024
Merged

Fix clang-tidy#64827
hanfei1991 merged 2 commits intomasterfrom
fix-clang-tidy-s3-queue

Conversation

@kssenii
Copy link
Copy Markdown
Member

@kssenii kssenii commented Jun 5, 2024 •
edited
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Clang-tidy
  • Allow: Unit tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All NOT Required Checks
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: Integration Tests
  • Exclude: Stateless tests
  • Exclude: Stateful tests
  • Exclude: Performance tests
  • Exclude: All with ASAN
  • Exclude: All with Aarch64
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Do not test
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@hanfei1991 hanfei1991 self-assigned this Jun 5, 2024
@hanfei1991
Copy link
Copy Markdown
Member

hanfei1991 commented Jun 5, 2024 

Jun 05 04:15:47 /build/src/Storages/S3Queue/S3QueueOrderedFileMetadata.cpp:374:16: error: unused local variable 'node_metadata_str' of type 'const std::string' (aka 'const basic_string<char, char_traits<char>, allocator<char>>') [bugprone-unused-local-non-trivial-variable,-warnings-as-errors]
Jun 05 04:15:47   374 |     const auto node_metadata_str = node_metadata.toString();
Jun 05 04:15:47       |                ^
Jun 05 04:15:47 34132 warnings generated.
Jun 05 04:15:47 Suppressed 34678 warnings (34131 in non-user code, 547 NOLINT).
Jun 05 04:15:47 Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
Jun 05 04:15:47 1 warning treated as error

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jun 5, 2024
@robot-clickhouse
Copy link
Copy Markdown
Member

robot-clickhouse commented Jun 5, 2024 •
edited by robot-clickhouse-ci-1
Loading

This is an automated comment for commit ba90cf2 with description of existing statuses. It's updated for the latest CI running

⏳ Click here to open a full report in a separate page

Check nameDescriptionStatus
A SyncIf it fails, ask a maintainer for help⏳ pending
Mergeable CheckChecks if all other necessary checks are successful⏳ pending
Successful checks
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
PR CheckChecks correctness of the PR's body✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success

@kssenii kssenii force-pushed the fix-clang-tidy-s3-queue branch from 2530572 to c25f8fa Compare June 5, 2024 08:58
@hanfei1991 hanfei1991 enabled auto-merge June 5, 2024 09:41
@azat azat mentioned this pull request Jun 5, 2024
Merged
@vdimir vdimir mentioned this pull request Jun 5, 2024
Merged
22 tasks
@hanfei1991 hanfei1991 added this pull request to the merge queue Jun 5, 2024
@Felixoid Felixoid mentioned this pull request Jun 5, 2024
Merged
22 tasks
Merged via the queue into master with commit 9b7944e Jun 5, 2024
@hanfei1991 hanfei1991 deleted the fix-clang-tidy-s3-queue branch June 5, 2024 12:38
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hanfei1991 hanfei1991 hanfei1991 approved these changes

Assignees

@hanfei1991 hanfei1991

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kssenii @hanfei1991 @robot-clickhouse @robot-ch-test-poll2