Get rid of dynamic allocation in ParsedJson::Iterator.#6479
Merged
vitlibar merged 1 commit intoClickHouse:masterfrom Aug 16, 2019
Merged
Get rid of dynamic allocation in ParsedJson::Iterator.#6479vitlibar merged 1 commit intoClickHouse:masterfrom
vitlibar merged 1 commit intoClickHouse:masterfrom
Conversation
alexey-milovidov
approved these changes
Aug 14, 2019
Member
alexey-milovidov
left a comment
alexey-milovidov
left a comment
There was a problem hiding this comment.
Performance test is Ok.
No idea about coverage failure - don't mind.
alexey-milovidov
approved these changes
Aug 15, 2019
Member
|
Approved. You only have to change submodule address to either ClickHouse_Extras or upstream. |
Member
Author
Yes, I know, I'm going to do it. |
vitlibar
force-pushed
the
no-allocation-in-simdjson-iterator
branch
from
4502bbd to
69ed527
Compare
vitlibar
changed the title
KochetovNicolai
added
the
pr-build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Try to update simdjson to a new version.