Make table functions always report engine 'StorageProxy' in system.tables#64771
Merged
alexey-milovidov merged 1 commit intomasterfrom Jun 4, 2024
Merged
Make table functions always report engine 'StorageProxy' in system.tables#64771alexey-milovidov merged 1 commit intomasterfrom
alexey-milovidov merged 1 commit intomasterfrom
Conversation
Contributor
|
This is an automated comment for commit 16bf3e3 with description of existing statuses. It's updated for the latest CI running ⏳ Click here to open a full report in a separate page
Successful checks
|
alexey-milovidov
approved these changes
Jun 4, 2024
Member
alexey-milovidov
left a comment
There was a problem hiding this comment.
This is a good solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
For table-function-based tables, the
engineshown insystem.tablescould change over time. E.g. (edited):This behavior (a) seems weird, and (b) made 02888_system_tables_with_inaccessible_table_function flaky. This PR makes the engine always be reported as 'StorageProxy'.
(Alternatively we could propagate the underlying engine name, probably by adding a new virtual function in
ITableFunctionand implementing it in all ~32 table functions. Or report the table function name instead of IStorage's name, that would be trivial. LMK if you think we should do that instead of 'StorageProxy'.)