Skip to content

Fix assertion when WriteBufferFromFileDecorator::preFinalize() throws#64768

Closed
al13n321 wants to merge 5 commits intomasterfrom
fin
Closed

Fix assertion when WriteBufferFromFileDecorator::preFinalize() throws#64768
al13n321 wants to merge 5 commits intomasterfrom
fin

Conversation

@al13n321
Copy link
Copy Markdown
Member

@al13n321 al13n321 commented Jun 3, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Should fix this test failure: https://s3.amazonaws.com/clickhouse-test-reports/63584/96c6ff58dcf3b6121697724e8bd5fafab43bb1c8/stress_test__tsan_.html (relevant bits of the server log: https://pastila.nl/?001f2f1b/15d04da91de2aa33e99daf180a8efd3e#fSl6r9/xKdrnRgtrVIsO1Q== )

There was already a comment in the code describing this exact scenario:

    /// In case of exception in preFinalize as a part of finalize call
    /// WriteBufferFromFileDecorator.finalized is set as true
    /// but impl->finalized is remain false
    /// That leads to situation when the destructor of impl is called with impl->finalized equal false.

... and then not mentioning any solution. I'm confused.

@al13n321 al13n321 requested a review from CheSema June 3, 2024 22:13
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jun 3, 2024
@robot-ch-test-poll1
Copy link
Copy Markdown
Contributor

robot-ch-test-poll1 commented Jun 3, 2024 •
edited by robot-ch-test-poll4
Loading

This is an automated comment for commit ce2b8e8 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@al13n321 al13n321 mentioned this pull request Jun 4, 2024
Merged
@CheSema CheSema self-assigned this Jun 4, 2024
CheSema
CheSema reviewed Jun 4, 2024
View reviewed changes
src/IO/WriteBufferFromFileDecorator.cpp Outdated
/// WriteBufferFromFileDecorator.finalized is set as true
/// but impl->finalized is remain false
/// That leads to situation when the destructor of impl is called with impl->finalized equal false.
impl->finalizeFailed();
Copy link
Copy Markdown
Member

@CheSema CheSema Jun 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to make impl->cancel() here
Im trying to implement it here #64478

Copy link
Copy Markdown
Member Author

@al13n321 al13n321 Jun 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I'll wait for #64478 to be merged and replace this with cancel().

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Aug 27, 2024

Dear @CheSema, this PR hasn't been updated for a while. You will be unassigned. Will you continue working on it? If so, please feel free to reassign yourself.

@CheSema
Copy link
Copy Markdown
Member

CheSema commented Nov 1, 2024

I suggest we cancel this in favor #68800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CheSema CheSema CheSema approved these changes

Assignees

No one assigned

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@al13n321 @robot-ch-test-poll1 @CheSema @alexey-milovidov