Skip to content

fix: function filters with token-based text indexes#64720

Merged
jkartseva merged 1 commit intoClickHouse:masterfrom
korowa:fix-split-tokenized-indices
Jun 6, 2024
Merged

fix: function filters with token-based text indexes#64720
jkartseva merged 1 commit intoClickHouse:masterfrom
korowa:fix-split-tokenized-indices

Conversation

@korowa
Copy link
Copy Markdown
Contributor

@korowa korowa commented Jun 1, 2024 •
edited
Loading

Closes #64337

This PR adds an ability to skip first/last tokens in SplitTokenExtractor, when building text index filters for substring-matching predicates, rather then considering input string as a set of complete tokens.

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fixed excessive part elimination by token-based text indexes (ngrambf , full_text) when filtering by result of startsWith, endsWith, match, multiSearchAny

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All NOT Required Checks
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: Integration Tests
  • Exclude: Stateless tests
  • Exclude: Stateful tests
  • Exclude: Performance tests
  • Exclude: All with ASAN
  • Exclude: All with Aarch64
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Do not test
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label Jun 3, 2024
@robot-ch-test-poll robot-ch-test-poll added the pr-bugfix Pull request with bugfix, not backported by default label Jun 3, 2024
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented Jun 3, 2024 •
edited by robot-ch-test-poll2
Loading

This is an automated comment for commit a7729d6 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR❌ failure
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
A SyncIf it fails, ask a maintainer for help✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
Bugfix validationChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@korowa korowa force-pushed the fix-split-tokenized-indices branch 2 times, most recently from 9e123b2 to f0ddeaf Compare June 3, 2024 18:42
@korowa korowa force-pushed the fix-split-tokenized-indices branch from f0ddeaf to a7729d6 Compare June 4, 2024 06:25
@korowa korowa mentioned this pull request Jun 4, 2024
Closed
21 tasks
@jkartseva jkartseva self-assigned this Jun 4, 2024
jkartseva
jkartseva approved these changes Jun 6, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jkartseva jkartseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkartseva jkartseva added this pull request to the merge queue Jun 6, 2024
Merged via the queue into ClickHouse:master with commit 94a8c7e Jun 6, 2024
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jun 6, 2024
@tavplubix tavplubix mentioned this pull request Jun 6, 2024
Merged
22 tasks
@azat azat mentioned this pull request Jun 6, 2024
Closed
1 task
azat added a commit to azat/ClickHouse that referenced this pull request Jun 6, 2024
@azat
Add missing allow_experimental_full_text_index
66ec799 
Conflicts between ClickHouse#64720 and ClickHouse#64656

Signed-off-by: Azat Khuzhin <[email protected]>
Algunenano added a commit to Algunenano/ClickHouse that referenced this pull request Jun 7, 2024
@Algunenano
Revert "Merge pull request ClickHouse#64720 from korowa/fix-split-tok…
a53ce56 
…enized-indices"

This reverts commit 94a8c7e, reversing
changes made to a197a53.
@robot-ch-test-poll robot-ch-test-poll added the pr-backports-created-cloud deprecated label, NOOP label Jun 28, 2024
@rschu1ze rschu1ze added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Sep 10, 2024
@robot-ch-test-poll4 robot-ch-test-poll4 mentioned this pull request Sep 10, 2024
Closed
@robot-ch-test-poll2 robot-ch-test-poll2 mentioned this pull request Sep 13, 2024
Closed
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkartseva jkartseva jkartseva approved these changes

Assignees

@jkartseva jkartseva

Labels

can be tested Allows running workflows for external contributors pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

startsWith on column with token-based bloom filter does not produce correct result

7 participants

@korowa @robot-ch-test-poll @jkartseva @alexey-milovidov @robot-ch-test-poll4 @rschu1ze @robot-clickhouse-ci-1