system.metric_log table #6467
Merged
alexey-milovidov merged 23 commits intoClickHouse:masterfrom Aug 15, 2019
Merged
Conversation
System metric log2
nikitamikhaylov
added
can be tested
and removed
do not test
dbms/src/Interpreters/MetricLog.cpp
Outdated
| std::string name; | ||
| name += "ProfileEvent_"; | ||
| name += ProfileEvents::getName(ProfileEvents::Event(i)); | ||
| columns_with_type_and_name.emplace_back(std::make_shared<DataTypeUInt64>(), name); |
Member
There was a problem hiding this comment.
std::move... or better: to construct inplace.
dbms/src/Interpreters/MetricLog.cpp
Outdated
| //ProfileEvents | ||
| for (size_t i = 0, end = ProfileEvents::end(); i < end; ++i) | ||
| { | ||
| const UInt64 value = ProfileEvents::global_counters[i]; |
Member
There was a problem hiding this comment.
.load(std::memory_order_relaxed)
dbms/src/Interpreters/SystemLog.cpp
Outdated
|
|
||
| if (metric_log) | ||
| { | ||
| constexpr size_t DEFAULT_METRIC_LOG_COLLECT_INTERVAL_MILLISECONDS = 1000; |
Member
There was a problem hiding this comment.
Let's make no default at all. (config.get... with throw an exception) and keep the value in example in config.
dbms/src/Interpreters/MetricLog.cpp
Outdated
| elem.event_time = std::chrono::system_clock::to_time_t(prev_timepoint); | ||
| this->add(elem); | ||
|
|
||
| desired_timepoint = prev_timepoint + std::chrono::milliseconds(collect_interval_milliseconds); |
Member
There was a problem hiding this comment.
What if you kill -STOP clickhouse-server* for a minute and then continue?
In you implementation, it will write multiple identical values after wakeup.
But it's better to skip dropped time points.
* it's totally real on production servers due to IO overload and page faults.
Member
|
Let's merge and wait for docker image to rebuild. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog. Remove if this is non-significant change.
Category (leave one):
Short description (up to few sentences):
Detailed description (optional):
To enable add
to
config.xml.#6363