Merged
Conversation
proller
reviewed
Aug 12, 2019
|
|
||
| if (NOT SANITIZE) | ||
| # TODO: only make this extra-checks in CI builds, since a lot of contrib libs won't link - | ||
| # CI works around this problem by explicitly adding GLIBC_COMPATIBILITY flag. |
Member
There was a problem hiding this comment.
Why we can't do it always?
Contributor
Author
There was a problem hiding this comment.
Because @proller complains that he can't build locally otherwise, and don't want to use extra flag as workaround.
Contributor
There was a problem hiding this comment.
Also it needed for arcadia
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog. Remove if this is non-significant change.
Category (leave one):
Short description (up to few sentences):
Enable back the check of undefined symbols while linking