Skip to content

Don't propagate user settings for background ops#64456

Merged
alesapin merged 3 commits intomasterfrom
dont_propagate_settings_for_merges
May 29, 2024
Merged

Don't propagate user settings for background ops#64456
alesapin merged 3 commits intomasterfrom
dont_propagate_settings_for_merges

Conversation

@alesapin
Copy link
Copy Markdown
Member

@alesapin alesapin commented May 27, 2024 •
edited
Loading

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Settings from user config doesn't affect merges and mutations for MergeTree on top of object storage.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings

NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step

  • Allow: Integration Tests
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Unit tests
  • Allow: Performance tests
  • Allow: All with aarch64
  • Allow: All with ASAN
  • Allow: All with TSAN
  • Allow: All with Analyzer
  • Allow: All with Azure
  • Allow: Add your option here
  • Exclude: Fast test
  • Exclude: Integration Tests
  • Exclude: Stateless tests
  • Exclude: Stateful tests
  • Exclude: Performance tests
  • Exclude: All with ASAN
  • Exclude: All with TSAN
  • Exclude: All with MSAN
  • Exclude: All with UBSAN
  • Exclude: All with Coverage
  • Exclude: All with Aarch64
  • do not test (only style check)
  • disable merge-commit (no merge from master before tests)
  • disable CI cache (job reuse)
  • allow: batch 1 for multi-batch jobs
  • allow: batch 2
  • allow: batch 3
  • allow: batch 4, 5 and 6

@alesapin alesapin changed the title Don't propagate user settings for merges and mutations in object stor… Don't propagate user settings for background ops May 27, 2024
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-improvement Pull request with some product improvements label May 27, 2024
@robot-clickhouse-ci-2
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-2 commented May 27, 2024 •
edited
Loading

This is an automated comment for commit 4499b44 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS⏳ pending
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Mergeable CheckChecks if all other necessary checks are successful⏳ pending
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure
Successful checks
Check nameDescriptionStatus
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success

@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented May 27, 2024

Introduced in #59767

@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented May 27, 2024

Fast test is broken :(

@kssenii kssenii self-assigned this May 28, 2024
@alesapin alesapin enabled auto-merge May 29, 2024 15:58
@alesapin alesapin added this pull request to the merge queue May 29, 2024
Merged via the queue into master with commit 71f7237 May 29, 2024
@alesapin alesapin deleted the dont_propagate_settings_for_merges branch May 29, 2024 20:52
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label May 29, 2024
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-backports-created-cloud deprecated label, NOOP label May 30, 2024
@nikitamikhaylov nikitamikhaylov mentioned this pull request May 31, 2024
Merged
22 tasks
@Felixoid Felixoid removed the pr-backports-created-cloud deprecated label, NOOP label Jun 7, 2024
@robot-ch-test-poll robot-ch-test-poll added the pr-backports-created-cloud deprecated label, NOOP label Jun 8, 2024
@arsenmuk arsenmuk mentioned this pull request Jan 12, 2026
Merged
1 task
arsenmuk added a commit that referenced this pull request Jan 20, 2026
@arsenmuk
Removed #64456 which is reduntant now, test remained as actual
8853d0a
arsenmuk added a commit that referenced this pull request Jan 20, 2026
@arsenmuk
Removed #64456 which is reduntant now, test remained as actual
15f76d2
arsenmuk added a commit that referenced this pull request Jan 20, 2026
@arsenmuk
Removed #64456 which is reduntant now, test remained as actual
b5d8bef
arsenmuk added a commit that referenced this pull request Jan 20, 2026
@arsenmuk
Removed #64456 which is reduntant now, test remained as actual
72d083d
arsenmuk added a commit that referenced this pull request Jan 20, 2026
@arsenmuk
Removed #64456 which is reduntant now, test remained as actual
80c824c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kssenii kssenii kssenii approved these changes

Assignees

@kssenii kssenii

Labels

pr-backports-created-cloud deprecated label, NOOP pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@alesapin @robot-clickhouse-ci-2 @kssenii @Felixoid @robot-ch-test-poll @robot-ch-test-poll4