Skip to content

Add chunked wrapper to native protocol#63781

Merged
yakov-olkhovskiy merged 61 commits intomasterfrom
ft-chunked-protocol
Aug 14, 2024
Merged

Add chunked wrapper to native protocol#63781
yakov-olkhovskiy merged 61 commits intomasterfrom
ft-chunked-protocol

Conversation

@yakov-olkhovskiy
Copy link
Copy Markdown
Member

@yakov-olkhovskiy yakov-olkhovskiy commented May 14, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Chunked wrapper for native protocol to accommodate CH-types independent proxy.

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label May 14, 2024
@robot-ch-test-poll1
Copy link
Copy Markdown
Contributor

robot-ch-test-poll1 commented May 14, 2024 •
edited by robot-clickhouse-ci-2
Loading

This is an automated comment for commit ae61464 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

alexey-milovidov
alexey-milovidov reviewed May 15, 2024
View reviewed changes
yakov-olkhovskiy and others added 23 commits May 15, 2024 20:47
@yakov-olkhovskiy
bugs fixed, switch chunk length to little endian
ad20488
@yakov-olkhovskiy
Merge branch 'master' into ft-chunked-protocol
ee74d0d
@yakov-olkhovskiy
fix, add some introspection functionality
6378184
@yakov-olkhovskiy
enable chunked before processing defaul database
5308256
@yakov-olkhovskiy
Merge branch 'master' into ft-chunked-protocol
7ea6eb9
@yakov-olkhovskiy
fix bug with profile stats in WriteBufferFromPocoSocket
9e747cd
@yakov-olkhovskiy
fix test
34702b3
@yakov-olkhovskiy
fix test
6c3556d
@yakov-olkhovskiy
process possibly remaining message after network error
69cd5ae
@yakov-olkhovskiy
fix spelling
99bd796
@yakov-olkhovskiy
add config parameters and client arguments, make default notchunked_o…
94bc0a1 
…ptional
@yakov-olkhovskiy
fix notchunked mode in ReadBufferFromPocoSocketChunked
147ad42
@yakov-olkhovskiy
major refactoring
89205d7
@yakov-olkhovskiy
fix
4545f3a
@yakov-olkhovskiy
fix
d1bc58f
@yakov-olkhovskiy
fix
1dc381d
@yakov-olkhovskiy
set chunked for testing
fdccba9
@yakov-olkhovskiy
set default protocol to notchunked_optional for cluster clients
e3d57ab
@yakov-olkhovskiy
fix special case of testing feature for chunked protocol
f11f414
@yakov-olkhovskiy
fix typos
eaeabd8
@yakov-olkhovskiy
fix test, better log, fix defaults for client
e0be652
@yakov-olkhovskiy
fix tidy build
66e3875
@yakov-olkhovskiy
fix tidy build
1cda459
@yakov-olkhovskiy
Copy link
Copy Markdown
Member Author

yakov-olkhovskiy commented Jul 10, 2024

tests look fine, returning notchunked defaults for merging

@nikitamikhaylov nikitamikhaylov mentioned this pull request Jul 23, 2024
Closed
@yakov-olkhovskiy yakov-olkhovskiy added this pull request to the merge queue Aug 14, 2024
Merged via the queue into master with commit f428020 Aug 14, 2024
@yakov-olkhovskiy yakov-olkhovskiy deleted the ft-chunked-protocol branch August 14, 2024 11:39
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 14, 2024
zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Dec 2, 2024
@yakov-olkhovskiy @zvonand
Merge pull request ClickHouse#63781 from ClickHouse/ft-chunked-protocol
35fa7f4 
Add chunked wrapper to native protocol
zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Dec 3, 2024
@yakov-olkhovskiy @zvonand
Merge pull request ClickHouse#63781 from ClickHouse/ft-chunked-protocol
4328c4f 
Add chunked wrapper to native protocol
@zvonand zvonand mentioned this pull request Dec 3, 2024
Merged
zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Dec 13, 2024
@yakov-olkhovskiy @zvonand
Merge pull request ClickHouse#63781 from ClickHouse/ft-chunked-protocol
e6bd2f7 
Add chunked wrapper to native protocol
zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Dec 17, 2024
@yakov-olkhovskiy @zvonand
Merge pull request ClickHouse#63781 from ClickHouse/ft-chunked-protocol
6e48f8a 
Add chunked wrapper to native protocol
Enmk pushed a commit to Altinity/ClickHouse that referenced this pull request Dec 22, 2024
@yakov-olkhovskiy @Enmk
Merge pull request ClickHouse#63781 from ClickHouse/ft-chunked-protocol
26b194b 
Add chunked wrapper to native protocol
@yakov-olkhovskiy yakov-olkhovskiy mentioned this pull request May 19, 2025
Open
1 task
@0xgouda 0xgouda mentioned this pull request Oct 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov left review comments

@Avogar Avogar Avogar approved these changes

Assignees

@Avogar Avogar

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yakov-olkhovskiy @robot-ch-test-poll1 @alexey-milovidov @Avogar @robot-ch-test-poll