Skip to content

Fix: remove redundant distinct with window functions#63776

Merged
devcrafter merged 3 commits intomasterfrom
fix-redundant-distinct-with-window
May 15, 2024
Merged

Fix: remove redundant distinct with window functions#63776
devcrafter merged 3 commits intomasterfrom
fix-redundant-distinct-with-window

Conversation

@devcrafter
Copy link
Copy Markdown
Member

@devcrafter devcrafter commented May 14, 2024 •
edited
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

query_plan_remove_redundant_distinct can break queries with WINDOW FUNCTIONS (with allow_experimental_analyzer is on). Fixes #62820

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

Modify your CI run

NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step

Include tests (required builds will be added automatically):

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Unit tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with Analyzer
  • All with Azure
  • Add your option here

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • Add your option here

Extra options:

  • do not test (only style check)
  • disable merge-commit (no merge from master before tests)
  • disable CI cache (job reuse)

Only specified batches in multi-batch jobs:

  • 1
  • 2
  • 3
  • 4
Details

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-bugfix Pull request with bugfix, not backported by default label May 14, 2024
@robot-clickhouse-ci-2
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-2 commented May 14, 2024 •
edited by robot-ch-test-poll
Loading

This is an automated comment for commit 595c593 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Bugfix validationChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

devcrafter
devcrafter commented May 14, 2024
View reviewed changes
src/Processors/QueryPlan/Optimizations/removeRedundantDistinct.cpp
break;
}

if (typeid_cast<const WindowStep *>(current_step))
Copy link
Copy Markdown
Member Author

@devcrafter devcrafter May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment

@KochetovNicolai KochetovNicolai self-assigned this May 14, 2024
@devcrafter devcrafter force-pushed the fix-redundant-distinct-with-window branch from 811b172 to 0f89be1 Compare May 14, 2024 16:14
@devcrafter devcrafter added this pull request to the merge queue May 15, 2024
Merged via the queue into master with commit 7a92996 May 15, 2024
@devcrafter devcrafter deleted the fix-redundant-distinct-with-window branch May 15, 2024 11:51
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label May 15, 2024
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request May 15, 2024
Merged
robot-clickhouse added a commit that referenced this pull request May 15, 2024
@robot-clickhouse
Backport #63776 to 23.8: Fix: remove redundant distinct with window f…
df9c838 
…unctions
This was referenced May 15, 2024
Merged
Merged
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request May 15, 2024
Merged
robot-clickhouse added a commit that referenced this pull request May 15, 2024
@robot-clickhouse
Backport #63776 to 24.2: Fix: remove redundant distinct with window f…
0e36a8f 
…unctions
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request May 15, 2024
Merged
robot-clickhouse added a commit that referenced this pull request May 15, 2024
@robot-clickhouse
Backport #63776 to 24.3: Fix: remove redundant distinct with window f…
9755101 
…unctions
This was referenced May 15, 2024
Merged
Merged
robot-clickhouse added a commit that referenced this pull request May 15, 2024
@robot-clickhouse
Backport #63776 to 24.4: Fix: remove redundant distinct with window f…
04b939d 
…unctions
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request May 15, 2024
Merged
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label May 15, 2024
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-backports-created-cloud deprecated label, NOOP label May 15, 2024
robot-clickhouse added a commit that referenced this pull request May 16, 2024
@robot-clickhouse
Merge pull request #63906 from ClickHouse/backport/24.3/63776
1644428 
Backport #63776 to 24.3: Fix: remove redundant distinct with window functions
robot-clickhouse-ci-2 added a commit that referenced this pull request May 16, 2024
@robot-clickhouse-ci-2
Merge pull request #63908 from ClickHouse/backport/24.4/63776
0119f99 
Backport #63776 to 24.4: Fix: remove redundant distinct with window functions
robot-ch-test-poll4 added a commit that referenced this pull request May 16, 2024
@robot-ch-test-poll4
Merge pull request #63904 from ClickHouse/backport/24.2/63776
238e7c6 
Backport #63776 to 24.2: Fix: remove redundant distinct with window functions
KochetovNicolai added a commit that referenced this pull request May 27, 2024
@KochetovNicolai
Merge pull request #63902 from ClickHouse/backport/23.8/63776
407e926 
Backport #63776 to 23.8: Fix: remove redundant distinct with window functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KochetovNicolai KochetovNicolai KochetovNicolai approved these changes

Assignees

@KochetovNicolai KochetovNicolai

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Exception Cannot find column if make select distinct from view and view contains window function and group by

6 participants

@devcrafter @robot-clickhouse-ci-2 @KochetovNicolai @robot-clickhouse @robot-ch-test-poll3 @robot-clickhouse-ci-1