Skip to content

Fix SimpleSquashingChunksTransform (02115_rewrite_local_join_right_di…#63691

Merged
vdimir merged 2 commits intomasterfrom
vdimir/fix_squashing_transform
May 23, 2024
Merged

Fix SimpleSquashingChunksTransform (02115_rewrite_local_join_right_di…#63691
vdimir merged 2 commits intomasterfrom
vdimir/fix_squashing_transform

Conversation

@vdimir
Copy link
Copy Markdown
Member

@vdimir vdimir commented May 13, 2024 •
edited by Felixoid
Loading

…stribute_table)

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Fix rare case with missing data in the result of distributed query

Close #62063

@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-bugfix Pull request with bugfix, not backported by default label May 13, 2024
@robot-ch-test-poll2
Copy link
Copy Markdown
Contributor

robot-ch-test-poll2 commented May 13, 2024 •
edited by robot-clickhouse
Loading

This is an automated comment for commit 39eef35 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Bugfix validationChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch❌ failure
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@devcrafter devcrafter self-assigned this May 13, 2024
@vdimir vdimir force-pushed the vdimir/fix_squashing_transform branch from 567e384 to d4edcce Compare May 14, 2024 10:29
@devcrafter
Copy link
Copy Markdown
Member

devcrafter commented May 14, 2024

AFAIU, the issue we've trying to fix here is correct handling tail data in SimpleSquashingChunksTransform after the input port is closed. But this was fixed for SimpleSquashingChunksTransform in #62451 . Do I miss something?

@vdimir
Copy link
Copy Markdown
Member Author

vdimir commented May 14, 2024

AFAIU, the issue we've trying to fix here is correct handling tail data in SimpleSquashingChunksTransform after the input port is closed. But this was fixed for SimpleSquashingChunksTransform in #62451 . Do I miss something?

@devcrafter
The mentioned fix addresses a similar issue but seems not to cover all the cases. One of the pitfalls is that input.isFinished() can be updated during the prepare execution. So, despite handling state, the ISimpleTransform::prepare can still return Finished. Essentially, SimpleSquashingChunksTransform::prepare should duplicate all logic of ISimpleTransform::prepare with a small difference, making it even more complicated. I decided to switch to IInflatingTransform, which is a bit more natural for processors that accumulate some data before returning it, in contrast to ISimpleTransform, which is supposed to transform data chunk by chunk.

@vdimir vdimir force-pushed the vdimir/fix_squashing_transform branch from 151c25d to 50784b4 Compare May 15, 2024 11:39
@vdimir vdimir force-pushed the vdimir/fix_squashing_transform branch from 50784b4 to 39eef35 Compare May 22, 2024 14:39
@vdimir vdimir added this pull request to the merge queue May 23, 2024
Merged via the queue into master with commit 70a1d3a May 23, 2024
@vdimir vdimir deleted the vdimir/fix_squashing_transform branch May 23, 2024 10:02
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label May 23, 2024
vdimir added a commit that referenced this pull request May 23, 2024
@vdimir
Followup for #63691
299f088
alexey-milovidov added a commit that referenced this pull request May 24, 2024
@alexey-milovidov
Merge pull request #64285 from ClickHouse/vdimir/squashing_transform_…
6c06772 
…followup

Followup for #63691
robot-clickhouse added a commit that referenced this pull request May 24, 2024
@robot-clickhouse
Backport #64285 to 24.5: Followup for #63691
3763c2d
vdimir added a commit that referenced this pull request May 24, 2024
@vdimir
Merge pull request #64346 from ClickHouse/backport/24.5/64285
6b45476 
Backport #64285 to 24.5: Followup for #63691
@vdimir vdimir mentioned this pull request Jul 4, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@devcrafter devcrafter

Labels

pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

02115_rewrite_local_join_right_distribute_table is flaky (under analyzer)

4 participants

@vdimir @robot-ch-test-poll2 @devcrafter @robot-clickhouse