Skip to content

Fix filter pushdown for Parquet and maybe StorageMerge#63642

Merged
alexey-milovidov merged 3 commits intomasterfrom
dawg
May 21, 2024
Merged

Fix filter pushdown for Parquet and maybe StorageMerge#63642
alexey-milovidov merged 3 commits intomasterfrom
dawg

Conversation

@al13n321
Copy link
Copy Markdown
Member

@al13n321 al13n321 commented May 11, 2024 •
edited
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fixed Parquet filter pushdown not working with Analyzer.

Situation:

/// Analyzer generates unique ColumnIdentifiers like __table1.__partition_id in filter nodes,
/// while key analysis still requires unqualified column names.

MergeTree had code to specifically correct for that, but other storages didn't, for some reason. So filter pushdown wasn't working for Parquet and probably ORC and maybe Merge.

Most of the PR is one find-replace. Non-mechanical changes are in ReadFromMergeTree.cpp, SelectQueryInfo.{h,cpp}, SourceStepWithFilter.cpp, and 02841_parquet_filter_pushdown.sql

Closes #53536

@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-bugfix Pull request with bugfix, not backported by default label May 11, 2024
@robot-ch-test-poll4
Copy link
Copy Markdown
Contributor

robot-ch-test-poll4 commented May 11, 2024 •
edited by robot-clickhouse-ci-2
Loading

This is an automated comment for commit 2e83043 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process❌ failure
Mergeable CheckChecks if all other necessary checks are successful❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
Bugfix validationChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@alexey-milovidov alexey-milovidov self-assigned this May 11, 2024
alexey-milovidov
alexey-milovidov requested changes May 11, 2024
View reviewed changes
@al13n321
Copy link
Copy Markdown
Member Author

al13n321 commented May 17, 2024

The test failures about system.zookeeper are clearly related, but I couldn't reproduce them locally so far. Maybe it needs fast-test-like build with reduced dependencies? Maybe something's different in server config? Maybe fast test passes some important arguments to clickhouse-test?

@al13n321
Copy link
Copy Markdown
Member Author

al13n321 commented May 17, 2024 •
edited
Loading

Maybe it needs fast-test-like build with reduced dependencies?

Didn't help.

Maybe fast test passes some important arguments to clickhouse-test?

Didn't help.

Maybe something's different in server config?

I tried to use tests/config/install.sh to create configs similar to CI, but getting it to work seems hopeless, I ran into a few different errors, the configs seem to be missing things, and it would take a while to follow the code and configs to figure out how exactly CI sets everything and try to do the same.

Is there a way to get CI to deploy everything, then pause and let me SSH to it?

@al13n321
Copy link
Copy Markdown
Member Author

al13n321 commented May 17, 2024

In #58061 is another example where the server takes very different code paths in CI vs locally.

@al13n321
Copy link
Copy Markdown
Member Author

al13n321 commented May 21, 2024 •
edited
Loading

(Ok, reproduced the CI setup by copying the commands from the CI log shown in github actions (thanks to whoever put a set +x there!), found the dumb bug in my code.)

@alexey-milovidov alexey-milovidov merged commit 14bff5c into master May 21, 2024
@alexey-milovidov alexey-milovidov deleted the dawg branch May 21, 2024 03:37
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label May 21, 2024
kssenii added a commit that referenced this pull request May 21, 2024
@kssenii
Apply change from PR #63642 (#63642)
96715f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make KeyCondition usable outside *MergeTree when analyzer is enabled

4 participants

@al13n321 @robot-ch-test-poll4 @alexey-milovidov @robot-ch-test-poll1