Skip to content

Backport #63513 to 24.3: Make MergeTreePrefetchedReadPool safer#63595

Merged
robot-clickhouse merged 2 commits into24.3from
backport/24.3/63513
May 21, 2024
Merged

Backport #63513 to 24.3: Make MergeTreePrefetchedReadPool safer#63595
robot-clickhouse merged 2 commits into24.3from
backport/24.3/63513

Conversation

@robot-ch-test-poll3
Copy link
Copy Markdown
Contributor

@robot-ch-test-poll3 robot-ch-test-poll3 commented May 10, 2024

Original pull-request #63513
Cherry-pick pull-request #63590

This pull-request is a last step of an automated backporting.
Treat it as a standard pull-request: look at the checks and resolve conflicts.
Merge it only if you intend to backport changes to the target branch, otherwise just close it.

@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backport Changes, backported to release branch. Do not use manually - automated use only! label May 10, 2024
@robot-ch-test-poll1
Copy link
Copy Markdown
Contributor

robot-ch-test-poll1 commented May 10, 2024 •
edited by robot-clickhouse
Loading

This is an automated comment for commit 07279c9 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success

@kssenii
Copy link
Copy Markdown
Member

kssenii commented May 21, 2024

@antonio2368 , let's close this backport? this version does not contan ThreadPoolCallbackRunnerLocal, so the build fails, not sure whether it is worth backporting the related pr as well to fix the build

@antonio2368
Copy link
Copy Markdown
Member

antonio2368 commented May 21, 2024

We can backport just the code for saving parent part and remove the ThreadPoolCallbackRunnerLocal related changes.
I will do it as I did it already for some other releases.
I forgot about this backport, thanks for checking it out.

@robot-clickhouse robot-clickhouse merged commit 157d6c4 into 24.3 May 21, 2024
@robot-clickhouse robot-clickhouse deleted the backport/24.3/63513 branch May 21, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@antonio2368 antonio2368

@kssenii kssenii

Labels

pr-backport Changes, backported to release branch. Do not use manually - automated use only!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@robot-ch-test-poll3 @robot-ch-test-poll1 @kssenii @antonio2368 @robot-clickhouse