Skip to content

Cherry pick #63513 to 24.2: Make MergeTreePrefetchedReadPool safer#63589

Merged
robot-clickhouse-ci-2 merged 4 commits intobackport/24.2/63513from
cherrypick/24.2/78af18ac87e58dd7e81b6161f5e114d8fa34ef67
May 10, 2024
Merged

Cherry pick #63513 to 24.2: Make MergeTreePrefetchedReadPool safer#63589
robot-clickhouse-ci-2 merged 4 commits intobackport/24.2/63513from
cherrypick/24.2/78af18ac87e58dd7e81b6161f5e114d8fa34ef67

Conversation

@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

@robot-ch-test-poll robot-ch-test-poll commented May 10, 2024

Original pull-request #63513

This pull-request is a first step of an automated backporting.
It contains changes similar to calling git cherry-pick locally.
If you intend to continue backporting the changes, then resolve all conflicts if any.
Otherwise, if you do not want to backport them, then just close this pull-request.

The check results does not matter at this step - you can safely ignore them.

Note

This pull-request will be merged automatically. Please, do not merge it manually (but if you accidentally did, nothing bad will happen).

Troubleshooting

If the PR was manually reopened after being closed

If this PR is stuck (i.e. not automatically merged after one day), check #63513 for pr-backports-created label and delete it.

Manually merging will do nothing. The pr-backports-created label prevents the original PR #63513 from being processed.

If the conflicts were resolved in a wrong way

If this cherry-pick PR is completely screwed by a wrong conflicts resolution, and you want to recreate it:

  • delete the pr-cherrypick label from the PR
  • delete this branch from the repository

You also need to check the original PR #63513 for pr-backports-created, and delete if it's presented there

@robot-ch-test-poll robot-ch-test-poll added pr-cherrypick Cherry-pick of merge-commit before backporting. Do not use manually - automated use only! do not test disable testing on pull request labels May 10, 2024
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor Author

robot-ch-test-poll commented May 10, 2024 •
edited by robot-ch-test-poll3
Loading

This is an automated comment for commit f3fcaa5 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 merged this pull request into backport/24.2/63513 May 10, 2024
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 deleted the cherrypick/24.2/78af18ac87e58dd7e81b6161f5e114d8fa34ef67 branch May 10, 2024 08:11
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request May 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@antonio2368 antonio2368

@kssenii kssenii

Labels

do not test disable testing on pull request pr-cherrypick Cherry-pick of merge-commit before backporting. Do not use manually - automated use only!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@robot-ch-test-poll @antonio2368 @kssenii @robot-clickhouse-ci-2