Skip to content

Track memory allocated by the arrow library#63584

Merged
alexey-milovidov merged 4 commits intomasterfrom
trek
Jun 4, 2024
Merged

Track memory allocated by the arrow library#63584
alexey-milovidov merged 4 commits intomasterfrom
trek

Conversation

@al13n321
Copy link
Copy Markdown
Member

@al13n321 al13n321 commented May 10, 2024

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fixed parquet memory tracking.

By default arrow allocates memory using posix_memalign(), which we don't equip with memory tracking. This PR tells it to use our tracked allocator instead.

Important because parquet reader may use lots of memory, specifically max_parsing_threads * [row group size]. That's often a few GBs, sometimes tens of GBs.

@al13n321 al13n321 requested a review from Avogar May 10, 2024 02:29
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-bugfix Pull request with bugfix, not backported by default label May 10, 2024
@robot-clickhouse-ci-1
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-1 commented May 10, 2024 •
edited by robot-ch-test-poll4
Loading

This is an automated comment for commit 26abb08 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Successful checks
Check nameDescriptionStatus
A SyncIf it fails, ask a maintainer for help✅ success
Bugfix validationChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@alexey-milovidov alexey-milovidov self-assigned this May 10, 2024
@al13n321 al13n321 force-pushed the trek branch 2 times, most recently from 14f08ce to 9306ddc Compare May 14, 2024 20:07
@al13n321 al13n321 force-pushed the trek branch 5 times, most recently from 009976f to 96c6ff5 Compare May 31, 2024 20:20
@al13n321
Copy link
Copy Markdown
Member Author

al13n321 commented Jun 4, 2024

All 4 test failures are unrelated: #64768 , #64770 , #64716 , #64771

@alexey-milovidov alexey-milovidov added this pull request to the merge queue Jun 4, 2024
Merged via the queue into master with commit 887a56d Jun 4, 2024
@alexey-milovidov alexey-milovidov deleted the trek branch June 4, 2024 04:31
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Jun 4, 2024
@nikitamikhaylov nikitamikhaylov mentioned this pull request Jul 20, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

@Avogar Avogar Awaiting requested review from Avogar

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@al13n321 @robot-clickhouse-ci-1 @alexey-milovidov @robot-ch-test-poll