Skip to content

Make MergeTreePrefetchedReadPool safer#63513

Merged
antonio2368 merged 2 commits intomasterfrom
threadpool-runner-local-prefetch-read-pool
May 10, 2024
Merged

Make MergeTreePrefetchedReadPool safer#63513
antonio2368 merged 2 commits intomasterfrom
threadpool-runner-local-prefetch-read-pool

Conversation

@antonio2368
Copy link
Copy Markdown
Member

@antonio2368 antonio2368 commented May 8, 2024

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Avoid segafult in MergeTreePrefetchedReadPool while fetching projection parts.

I used ThreadPoolCallbackRunnerLocal to make it safer in general and I added parent part to MergeTreeReadTaskInfo in case we need to access it while reading a projection part.

Based on my understanding, we don't keep snapshot of all parts throughout the query execution but only up to initialization. https://github.com/ClickHouse/ClickHouse/blob/master/src/Processors/QueryPlan/ReadFromMergeTree.cpp#L1978

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

Modify your CI run

NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step

Include tests (required builds will be added automatically):

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Unit tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with Analyzer
  • All with Azure
  • Add your option here

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • Add your option here

Extra options:

  • do not test (only style check)
  • disable merge-commit (no merge from master before tests)
  • disable CI cache (job reuse)

Only specified batches in multi-batch jobs:

  • 1
  • 2
  • 3
  • 4
Details

@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-bugfix Pull request with bugfix, not backported by default label May 8, 2024
@robot-ch-test-poll3
Copy link
Copy Markdown
Contributor

robot-ch-test-poll3 commented May 8, 2024 •
edited by robot-ch-test-poll2
Loading

This is an automated comment for commit 173d5d0 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Bugfix validationChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch❌ failure
Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@antonio2368 antonio2368 force-pushed the threadpool-runner-local-prefetch-read-pool branch from 52342d4 to 173d5d0 Compare May 8, 2024 11:08
@kssenii kssenii self-assigned this May 8, 2024
@antonio2368 antonio2368 added this pull request to the merge queue May 10, 2024
Merged via the queue into master with commit 78af18a May 10, 2024
@antonio2368 antonio2368 deleted the threadpool-runner-local-prefetch-read-pool branch May 10, 2024 07:56
@antonio2368 antonio2368 added pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels May 10, 2024
This was referenced May 10, 2024
Closed
Merged
Merged
Merged
robot-clickhouse added a commit that referenced this pull request May 10, 2024
@robot-clickhouse
Backport #63513 to 24.4: Make MergeTreePrefetchedReadPool safer
15ac1f1
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request May 10, 2024
Merged
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label May 10, 2024
robot-clickhouse added a commit that referenced this pull request May 10, 2024
@robot-clickhouse
Backport #63513 to 24.2: Make MergeTreePrefetchedReadPool safer
3c1c857
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request May 10, 2024
Merged
robot-clickhouse added a commit that referenced this pull request May 10, 2024
@robot-clickhouse
Backport #63513 to 24.3: Make MergeTreePrefetchedReadPool safer
d904207
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request May 10, 2024
Merged
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label May 10, 2024
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-backports-created-cloud deprecated label, NOOP label May 10, 2024
robot-clickhouse added a commit that referenced this pull request May 10, 2024
@robot-clickhouse
Merge pull request #63594 from ClickHouse/backport/24.2/63513
773d404 
Backport #63513 to 24.2: Make `MergeTreePrefetchedReadPool` safer
kssenii added a commit that referenced this pull request May 21, 2024
@kssenii
Merge pull request #63592 from ClickHouse/backport/24.4/63513
59a5fab 
Backport #63513 to 24.4: Make `MergeTreePrefetchedReadPool` safer
robot-clickhouse added a commit that referenced this pull request May 21, 2024
@robot-clickhouse
Merge pull request #63595 from ClickHouse/backport/24.3/63513
157d6c4 
Backport #63513 to 24.3: Make `MergeTreePrefetchedReadPool` safer
@amosbird amosbird mentioned this pull request Jun 3, 2025
Merged
1 task
@sunny19930321 sunny19930321 mentioned this pull request Jul 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kssenii kssenii kssenii approved these changes

Assignees

@kssenii kssenii

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@antonio2368 @robot-ch-test-poll3 @kssenii @robot-ch-test-poll2 @robot-ch-test-poll4