Skip to content

Tabs in pretty format#63493

Merged
alexey-milovidov merged 3 commits intoClickHouse:masterfrom
Volodyachan:fix-tabs-in-pretty-format
May 9, 2024
Merged

Tabs in pretty format#63493
alexey-milovidov merged 3 commits intoClickHouse:masterfrom
Volodyachan:fix-tabs-in-pretty-format

Conversation

@Volodyachan
Copy link
Copy Markdown
Contributor

@Volodyachan Volodyachan commented May 7, 2024

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fixed tabulation from line numbering, correct handling of length when moving a line if the value has a tab, added tests

Example of current output

   ┏━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━┓
   ┃ id ┃ value     ┃ value1         ┃
   ┡━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━┩
1. │  0 │ test test │ 	something │
   └────┴───────────┴────────────────┘

    id   value   value1   

1.   0   test …  something 
        …	test

My output

   ┏━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━┓
   ┃ id ┃ value     ┃ value1      ┃
   ┡━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━┩
1. │  0 │ test test │ 	something │
   └────┴───────────┴─────────────┘

    id   value         value1   

1.   0   test       …  something 
        …	test

@nikitamikhaylov nikitamikhaylov added the can be tested Allows running workflows for external contributors label May 7, 2024
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-improvement Pull request with some product improvements label May 7, 2024
@robot-ch-test-poll2
Copy link
Copy Markdown
Contributor

robot-ch-test-poll2 commented May 7, 2024 •
edited by robot-clickhouse
Loading

This is an automated comment for commit c52af8c with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@antaljanosbenjamin antaljanosbenjamin self-assigned this May 8, 2024
antaljanosbenjamin
antaljanosbenjamin approved these changes May 8, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@antaljanosbenjamin antaljanosbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I didn't understand the changes fully, but they makes sense and I played with the built binary, I couldn't find any regression compared to previous version, but lots of improvements! Thanks for them!

@alexey-milovidov alexey-milovidov added this pull request to the merge queue May 9, 2024
Merged via the queue into ClickHouse:master with commit 8ed2456 May 9, 2024
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label May 9, 2024
@Algunenano Algunenano mentioned this pull request May 16, 2024
Merged
Algunenano added a commit to Algunenano/ClickHouse that referenced this pull request May 16, 2024
@Algunenano
Revert "Merge pull request ClickHouse#63493 from Volodyachan/fix-tabs…
610801f 
…-in-pretty-format"

This reverts commit 8ed2456, reversing
changes made to 7be88cc.
@Algunenano Algunenano mentioned this pull request May 16, 2024
Merged
Volodyachan added a commit to Volodyachan/ClickHouse that referenced this pull request May 18, 2024
@Volodyachan
Revert "Revert "Merge pull request ClickHouse#63493 from Volodyachan/…
94a71e9 
…fix-tabs-in-pretty-format""

This reverts commit 610801f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antaljanosbenjamin antaljanosbenjamin antaljanosbenjamin approved these changes

Assignees

@antaljanosbenjamin antaljanosbenjamin

Labels

can be tested Allows running workflows for external contributors pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Volodyachan @robot-ch-test-poll2 @antaljanosbenjamin @alexey-milovidov @nikitamikhaylov @robot-ch-test-poll3