Merged
Conversation
robot-ch-test-poll3
added
the
pr-bugfix
Contributor
|
This is an automated comment for commit f070462 with description of existing statuses. It's updated for the latest CI running ✅ Click here to open a full report in a separate page Successful checks
|
novikd
reviewed
May 7, 2024
Comment on lines
4818
to
4829
Member
There was a problem hiding this comment.
Hmm. Interesting case.
Is it about something like SELECT ... GROUP BY ... ORDER BY *?
Member
Author
There was a problem hiding this comment.
Should be the same, we resolve * using the same method not depending on it's source as usual identifiers. Added tests for it
Comment on lines
431
to
433
Member
There was a problem hiding this comment.
Makes sense. But it sad, that group_by_use_nulls limits optimizations so much..Do you think it's possible to update the types in the DAG?
Member
Author
There was a problem hiding this comment.
Probably yes, but I cannot come up with solution from the top of my head
vdimir
force-pushed
the
vdimir/group_by_use_nulls_fixes
branch
from
26846bd to
c67a43e
Compare
vdimir
commented
May 7, 2024
|
|
||
| void validateFilter(const QueryTreeNodePtr & filter_node, std::string_view exception_place_message, const QueryTreeNodePtr & query_node) | ||
| { | ||
| if (filter_node->getNodeType() == QueryTreeNodeType::LIST) |
Member
Author
There was a problem hiding this comment.
Now error is better, I will adjust the test https://s3.amazonaws.com/clickhouse-test-reports/63405/c67a43e3a7354c3db488df44c05e5a0d56a454c5/fast_test.html
2024-05-07 16:51:58 Code: 36. DB::Exception: Received from localhost:9000. DB::Exception: Unsupported expression '*' in filter. (BAD_ARGUMENTS)
2024-05-07 16:51:58 (query: SELECT * WHERE *; -- { serverError UNSUPPORTED_METHOD })
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
GROUPING SETSandWHEREandgroup_by_use_nulls = true, close Logical error 'Unexpected return type from equals' in group_by_use_nulls + GROUPING SETS #60538Documentation entry for user-facing changes
Modify your CI run
NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step
Include tests (required builds will be added automatically):
Exclude tests:
Extra options:
Only specified batches in multi-batch jobs:
Details