Skip to content

Analyzer: Refactor ConstantNode#63198

Merged
yakov-olkhovskiy merged 37 commits intomasterfrom
analyzer-constants-refactoring
Dec 28, 2024
Merged

Analyzer: Refactor ConstantNode#63198
yakov-olkhovskiy merged 37 commits intomasterfrom
analyzer-constants-refactoring

Conversation

@novikd
Copy link
Copy Markdown
Member

@novikd novikd commented Apr 30, 2024

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Improve new analyzer infrastructure performance via storing ColumnPtr instead of Field in the ConstantNode. Related to #62245.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

Modify your CI run:

NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step

Include tests (required builds will be added automatically):

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Unit tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with Analyzer
  • Add your option here

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • Add your option here

Extra options:

  • do not test (only style check)
  • disable merge-commit (no merge from master before tests)
  • disable CI cache (job reuse)

Only specified batches in multi-batch jobs:

  • 1
  • 2
  • 3
  • 4

@novikd novikd added analyzer Issues and pull-requests related to new analyzer v24.3-must-backport labels Apr 30, 2024
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-improvement Pull request with some product improvements label Apr 30, 2024
@robot-ch-test-poll3
Copy link
Copy Markdown
Contributor

robot-ch-test-poll3 commented Apr 30, 2024 •
edited
Loading

This is an automated comment for commit 5f706ae with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@vdimir
Copy link
Copy Markdown
Member

vdimir commented May 2, 2024

Tests should be easy to fix

2024.04.30 18:44:37.378482 [ 181713 ] {} <Fatal> BaseDaemon: (version 24.4.1.1, build id: D1BDCDB9412608E981FE716D390AC1A8504D75F9, git hash: 82eda17cc619808ee528b14d47666ba4bf310ddd) (from thread 171436) (query_id: ad2d7db9-e02b-4bbf-9834-0bb0ed9d2528) (query: SELECT (SELECT 1) AS subquery, 1 AS subquery;) Received signal Segmentation fault (11))

vdimir
vdimir approved these changes May 2, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@vdimir vdimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks clear and sane

@vdimir vdimir self-assigned this May 2, 2024
@novikd
Copy link
Copy Markdown
Member Author

novikd commented May 2, 2024

Tests should be easy to fix

Actually, there is a problem that I don't know how to fix yet. In ConstantNode::updateTreeHashImpl we try to call ColumnObject::updateHashFast which is not implemented.
It's unclear how to handle this case.

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jun 25, 2024

Dear @vdimir, this PR hasn't been updated for a while. You will be unassigned. Will you continue working on it? If so, please feel free to reassign yourself.

@vdimir vdimir self-assigned this Jun 27, 2024
@vdimir vdimir marked this pull request as draft June 27, 2024 11:11
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Aug 27, 2024

Dear @novikd, this PR hasn't been updated for a while. Will you continue working on it? If not, please close it. Otherwise, ignore this message.

@yakov-olkhovskiy yakov-olkhovskiy added this pull request to the merge queue Dec 28, 2024
Merged via the queue into master with commit f945405 Dec 28, 2024
@yakov-olkhovskiy yakov-olkhovskiy deleted the analyzer-constants-refactoring branch December 28, 2024 16:37
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Dec 28, 2024
@robot-clickhouse robot-clickhouse mentioned this pull request Dec 28, 2024
Closed
@novikd novikd mentioned this pull request Jan 3, 2025
Closed
9 tasks
@Avogar Avogar mentioned this pull request Jan 3, 2025
Closed
23 tasks
This was referenced Jan 7, 2025
Closed
Closed
Closed
Merged
@Avogar Avogar mentioned this pull request Jan 22, 2025
Closed
@Avogar Avogar mentioned this pull request Jan 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdimir vdimir vdimir approved these changes

Assignees

@yakov-olkhovskiy yakov-olkhovskiy

Labels

analyzer Issues and pull-requests related to new analyzer pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@novikd @robot-ch-test-poll3 @vdimir @alexey-milovidov @robot-ch-test-poll4 @yakov-olkhovskiy @KochetovNicolai