Fix possible CHECKSUM_DOESNT_MATCH (and others) during replicated fetches by azat · Pull Request #62987 · ClickHouse/ClickHouse

azat · 2024-04-25T15:19:50Z

Changelog category (leave one):

Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix possible CHECKSUM_DOESNT_MATCH (and others) during replicated fetches

Previously HTTP server didn't try to send an exception if something had
been written to the client already, but after rewriting to "zero-copy"
HTTP implementation (back in #19516) this got broken, and you can get
pretty "dangerous" at least at first glance errors, like:

Malformed chunked encoding
or most likely to CHECKSUM_DOESNT_MATCH error

This is not crucial because it will never pass checksum checks, but
still icky. So let's fix it.

P.S. this PR also adds failpoint for the test, but maybe it does not worth it, then I can drop the failpoint and the test itself.

robot-ch-test-poll2 · 2024-04-25T15:21:01Z

This is an automated comment for commit cf1451e with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check name	Description	Status
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	⏳ pending
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	❌ failure

Successful checks

Check name	Description	Status
A Sync	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	✅ success
Bugfix validation	Checks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch	✅ success
ClickBench	Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table	✅ success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker keeper image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docker server image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docs check	Builds and tests the documentation	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	✅ success
Mergeable Check	Checks if all other necessary checks are successful	✅ success
PR Check	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

src/Server/HTTP/HTTPServerResponse.cpp

src/Server/HTTP/HTTPServerResponse.h

Signed-off-by: Azat Khuzhin <[email protected]>

Previously HTTP server does not tries to send exception if something had been written to the client already, but after rewriting to "zero-copy" HTTP implementation (back in ClickHouse#19516) this got broken, and you can get pretty "dangerous" at least at first glance errors, like: - Malformed chunked encoding - or most likely to CHECKSUM_DOESNT_MATCH error This is not crucial because it will never pass checksum checks, but still icky. So let's fix it. Signed-off-by: Azat Khuzhin <[email protected]>

…ers) during replicated fetches It is not possible to fix it reliably after server started to write exceptions in the response body in case of errors, so let's just revert all of this. The DataPartsExchange is safe anyway, since it has proper checksums.

…etches-fix Revert #62987 - Fix possible CHECKSUM_DOESNT_MATCH (and others) during replicated fetches

robot-ch-test-poll2 added the pr-bugfix Pull request with bugfix, not backported by default label Apr 25, 2024

alexey-milovidov reviewed Apr 27, 2024

View reviewed changes

src/Server/HTTP/HTTPServerResponse.cpp Outdated Show resolved Hide resolved

alexey-milovidov reviewed Apr 27, 2024

View reviewed changes

src/Server/HTTP/HTTPServerResponse.h Outdated Show resolved Hide resolved

alexey-milovidov self-assigned this Apr 27, 2024

azat added 4 commits April 28, 2024 07:34

Add copy_data_failpoint failpoint

d278866

Signed-off-by: Azat Khuzhin <[email protected]>

Add a test for fetches failures

43dcc01

Signed-off-by: Azat Khuzhin <[email protected]>

Improve error message on checksum mismatch during fetches

478ba92

Signed-off-by: Azat Khuzhin <[email protected]>

azat force-pushed the fetches-exceptions-on-http branch from 6bc15a3 to cf1451e Compare April 28, 2024 05:34

alexey-milovidov added this pull request to the merge queue Apr 28, 2024

Merged via the queue into ClickHouse:master with commit 9826338 Apr 28, 2024

robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Apr 28, 2024

azat deleted the fetches-exceptions-on-http branch April 29, 2024 05:02

Algunenano mentioned this pull request Nov 5, 2025

tests: fix 03141_fetches_errors_stress #89583

Closed

azat mentioned this pull request Dec 19, 2025

Revert #62987 - Fix possible CHECKSUM_DOESNT_MATCH (and others) during replicated fetches #92730

Merged

alexey-milovidov added a commit that referenced this pull request Dec 20, 2025

Merge pull request #92730 from azat/revert-CHECKSUM_DOESNT_MATCH-on-f…

78de8be

…etches-fix Revert #62987 - Fix possible CHECKSUM_DOESNT_MATCH (and others) during replicated fetches

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix possible CHECKSUM_DOESNT_MATCH (and others) during replicated fetches#62987

Fix possible CHECKSUM_DOESNT_MATCH (and others) during replicated fetches#62987
alexey-milovidov merged 4 commits intoClickHouse:masterfrom
azat:fetches-exceptions-on-http

azat commented Apr 25, 2024 •

edited by alexey-milovidov

Loading

Uh oh!

robot-ch-test-poll2 commented Apr 25, 2024 •

edited by robot-clickhouse-ci-1

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

azat commented Apr 25, 2024 • edited by alexey-milovidov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Uh oh!

robot-ch-test-poll2 commented Apr 25, 2024 • edited by robot-clickhouse-ci-1 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

azat commented Apr 25, 2024 •

edited by alexey-milovidov

Loading

robot-ch-test-poll2 commented Apr 25, 2024 •

edited by robot-clickhouse-ci-1

Loading