Skip to content

Fix memory leak in groupArraySorted#62597

Merged
antonio2368 merged 1 commit intomasterfrom
memory-leak-grouparrysorted
Apr 15, 2024
Merged

Fix memory leak in groupArraySorted#62597
antonio2368 merged 1 commit intomasterfrom
memory-leak-grouparrysorted

Conversation

@antonio2368
Copy link
Copy Markdown
Member

@antonio2368 antonio2368 commented Apr 12, 2024

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix memory leak in groupArraySorted. Fix #62536

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

Modify your CI run:

NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step

Include tests (required builds will be added automatically):

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Unit tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with Analyzer
  • Add your option here

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • Add your option here

Extra options:

  • do not test (only style check)
  • disable merge-commit (no merge from master before tests)
  • disable CI cache (job reuse)

Only specified batches in multi-batch jobs:

  • 1
  • 2
  • 3
  • 4

@antonio2368 antonio2368 changed the title Fix memory like in groupArraySorted Fix memory leak in groupArraySorted Apr 12, 2024
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-bugfix Pull request with bugfix, not backported by default label Apr 12, 2024
@robot-clickhouse-ci-1
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-1 commented Apr 12, 2024 •
edited
Loading

This is an automated comment for commit ddd477a with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc❌ failure
Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@Algunenano Algunenano self-assigned this Apr 12, 2024
Algunenano
Algunenano approved these changes Apr 12, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Algunenano Algunenano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Maybe we should disallow using PODArray with non POD types completely, but I've just tested it and that requires a major refactor.

@antonio2368 antonio2368 mentioned this pull request Apr 12, 2024
Closed
@Algunenano Algunenano added pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Apr 13, 2024
@antonio2368 antonio2368 added this pull request to the merge queue Apr 15, 2024
Merged via the queue into master with commit 54871f0 Apr 15, 2024
@antonio2368 antonio2368 deleted the memory-leak-grouparrysorted branch April 15, 2024 08:23
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Apr 15, 2024
This was referenced Apr 15, 2024
Closed
Closed
Merged
robot-clickhouse added a commit that referenced this pull request Apr 15, 2024
@robot-clickhouse
Backport #62597 to 24.2: Fix memory leak in groupArraySorted
058f32e
This was referenced Apr 15, 2024
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Apr 15, 2024
@robot-clickhouse
Backport #62597 to 24.3: Fix memory leak in groupArraySorted
144e1dc
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 mentioned this pull request Apr 15, 2024
Merged
@robot-ch-test-poll robot-ch-test-poll added pr-backports-created-cloud deprecated label, NOOP pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore labels Apr 15, 2024
Algunenano added a commit that referenced this pull request Apr 15, 2024
@Algunenano
Merge pull request #62639 from ClickHouse/backport/24.2/62597
eeadc2f 
Backport #62597 to 24.2: Fix memory leak in groupArraySorted
Algunenano added a commit that referenced this pull request Apr 15, 2024
@Algunenano
Merge pull request #62641 from ClickHouse/backport/24.3/62597
cf6d623 
Backport #62597 to 24.3: Fix memory leak in groupArraySorted
@zvonand zvonand mentioned this pull request Apr 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Algunenano Algunenano Algunenano approved these changes

Assignees

@Algunenano Algunenano

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Memory leak in groupArraySorted function

5 participants

@antonio2368 @robot-clickhouse-ci-1 @Algunenano @robot-ch-test-poll @robot-ch-test-poll4