Skip to content

Fix SimpleSquashingChunksTransform#62451

Merged
nickitat merged 3 commits intoClickHouse:masterfrom
nickitat:fix_simple_squashing_transform
Apr 12, 2024
Merged

Fix SimpleSquashingChunksTransform#62451
nickitat merged 3 commits intoClickHouse:masterfrom
nickitat:fix_simple_squashing_transform

Conversation

@nickitat
Copy link
Copy Markdown
Member

@nickitat nickitat commented Apr 9, 2024 •
edited
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fixed rare bug in SimpleSquashingChunksTransform that may lead to a loss of the last chunk of data in a stream.

Analyzer became a victim, because it puts SimpleSquashingChunksTransform before MemorySink when collecting data into a temp table.

Fixes: #62173 #62192

@nickitat nickitat mentioned this pull request Apr 9, 2024
Merged
@robot-ch-test-poll robot-ch-test-poll added the pr-bugfix Pull request with bugfix, not backported by default label Apr 9, 2024
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented Apr 9, 2024 •
edited by robot-ch-test-poll2
Loading

This is an automated comment for commit 8b38fab with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Bugfix validationChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch❌ failure
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@devcrafter devcrafter self-assigned this Apr 9, 2024
devcrafter
devcrafter reviewed Apr 9, 2024
View reviewed changes
@nickitat
Copy link
Copy Markdown
Member Author

nickitat commented Apr 10, 2024

AST fuzzer (ubsan) - #62486
Stateless tests (debug) [2/5] - #62487
Stateful tests (msan) - #62252

@nickitat nickitat requested a review from devcrafter April 10, 2024 13:37
devcrafter
devcrafter reviewed Apr 10, 2024
View reviewed changes
@nickitat nickitat force-pushed the fix_simple_squashing_transform branch from 14caa91 to 8b38fab Compare April 11, 2024 12:36
@nickitat nickitat added this pull request to the merge queue Apr 12, 2024
Merged via the queue into ClickHouse:master with commit cab7e76 Apr 12, 2024
@nickitat nickitat deleted the fix_simple_squashing_transform branch April 12, 2024 13:14
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Apr 12, 2024
@devcrafter devcrafter mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antaljanosbenjamin antaljanosbenjamin antaljanosbenjamin left review comments

@devcrafter devcrafter devcrafter approved these changes

Assignees

@devcrafter devcrafter

Labels

pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

00088_global_in_one_shard_and_rows_before_limit is flaky

4 participants

@nickitat @robot-ch-test-poll @devcrafter @antaljanosbenjamin