support mask password when show create query#6240
Closed
zhang2014 wants to merge 3 commits intoClickHouse:masterfrom
Closed
support mask password when show create query#6240zhang2014 wants to merge 3 commits intoClickHouse:masterfrom
zhang2014 wants to merge 3 commits intoClickHouse:masterfrom
Conversation
zhang2014
force-pushed
the
feature/specific_function_parser
branch
from
5d46119 to
f9291c7
Compare
Contributor
Author
|
@akuzm Done. |
zhang2014
changed the title
Merged
Contributor
|
This patch introduces a lot of complexity. 34 files patched, many prototypes changes. Perhaps it's time to come up with a clean way to store hostname/secrets/credentials instead? Either in flat file, a table or similar. The logic is already there for dictionaries and could be reused. We had a security alert weeks ago due to MySQL passwords and hostnames being exposed in CH SQL admin/query tools recently. Adding masking code to every tool isn't possible. Apologies for the fly-by comment if this has already been discussed. Related: #6358 |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
blinkov
added
pr-feature
Contributor
Author
|
@geldot is right. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Category (leave one):
Short description (up to few sentences):
Passwords that support masking MySQL engines and maybe related #6217
Fixes #3311