Skip to content

More complex locking in StackTrace::toString#62332

Merged
antonio2368 merged 1 commit intomasterfrom
more-complex-stacktrace-locking
Apr 9, 2024
Merged

More complex locking in StackTrace::toString#62332
antonio2368 merged 1 commit intomasterfrom
more-complex-stacktrace-locking

Conversation

@antonio2368
Copy link
Copy Markdown
Member

@antonio2368 antonio2368 commented Apr 5, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

Modify your CI run:

NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step

Include tests (required builds will be added automatically):

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Unit tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with Analyzer
  • Add your option here

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • Add your option here

Extra options:

  • do not test (only style check)
  • disable merge-commit (no merge from master before tests)
  • disable CI cache (job reuse)

Only specified batches in multi-batch jobs:

  • 1
  • 2
  • 3
  • 4

@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Apr 5, 2024
@robot-ch-test-poll4
Copy link
Copy Markdown
Contributor

robot-ch-test-poll4 commented Apr 5, 2024 •
edited by robot-clickhouse
Loading

This is an automated comment for commit f7fdb2c with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS⏳ pending
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Mergeable CheckChecks if all other necessary checks are successful❌ failure
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@antonio2368 antonio2368 marked this pull request as ready for review April 8, 2024 07:01
@serxa serxa self-assigned this Apr 8, 2024
@serxa
Copy link
Copy Markdown
Member

serxa commented Apr 8, 2024

Why cannot we change the lock type to SharedMutex? First lock shared and try to just read from cache. If it fails: unlock shared, lock exclusive, check again if it is in cache. If hit - return from cache, if not - run toStringEveryLineImpl() under lock? I guess my question is: what is the exact problem? too high lock contention or too frequent (and slow) calls to toStringEveryLineImpl()?

If it is the second, then maybe the cache is wrong? Because it should be relatively small IMO, but it grows indefinitely.

@antonio2368
Copy link
Copy Markdown
Member Author

antonio2368 commented Apr 8, 2024

I guess my question is: what is the exact problem? too high lock contention or too frequent (and slow) calls to toStringEveryLineImpl()?

I saw some clusters being stuck on the cache lock, which could be explained with some deadlock/error in fetching string lines or by really slow execution of toStringEveryLineImpl (also could be because of some bug).
I noticed that in that situation a lot of exceptions are generated at the same time and almost all of them are blocked on the cache lock so I was thinking that we could at least reduce contention on cache while different stacktraces are generated in parallel.

Simpler solution would be to unlock the cache while creating string, but I added cv to try avoiding doing same work twice.

This was just an idea I quickly implemented to see opinions, so I can easily close this if it doesn't make sense to you.

@antonio2368 antonio2368 enabled auto-merge April 9, 2024 07:03
@antonio2368 antonio2368 added this pull request to the merge queue Apr 9, 2024
Merged via the queue into master with commit f6af63e Apr 9, 2024
@antonio2368 antonio2368 deleted the more-complex-stacktrace-locking branch April 9, 2024 12:47
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Apr 9, 2024
@serxa serxa mentioned this pull request Apr 9, 2024
Merged
29 tasks
@alexey-milovidov alexey-milovidov mentioned this pull request Jul 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serxa serxa serxa approved these changes

Assignees

@serxa serxa

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@antonio2368 @robot-ch-test-poll4 @serxa @robot-clickhouse