Skip to content

Fix flaky test_broken_projestions/test.py::test_broken_ignored_replic…#61932

Merged
kssenii merged 1 commit intomasterfrom
fix-flaky-test-broke-projections
Mar 26, 2024
Merged

Fix flaky test_broken_projestions/test.py::test_broken_ignored_replic…#61932
kssenii merged 1 commit intomasterfrom
fix-flaky-test-broke-projections

Conversation

@kssenii
Copy link
Copy Markdown
Member

@kssenii kssenii commented Mar 26, 2024 •
edited
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

This is strange that there was no record by certain query_id even after system flush logs, but according to debug logging in test it was there after the second try (second try was the printing of debug info before abort) https://pastila.nl/?0075caf2/3ff9b5c94c6925196627cd3d80fe494b#8Kb3T85WOEfDlrf6RR0gaQ==

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

Modify your CI run:

NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Set desired options before CI starts or re-push after updates

Run only:

  • Integration tests
  • Integration tests (arm64)
  • Stateless tests (release)
  • Stateless tests (asan)
  • Stateful tests (release)
  • Stateful tests (asan)
  • No sanitizers
  • Tests with analyzer
  • Fast tests
  • Only package_debug build
  • Add your CI variant description here

CI options:

  • do not test (only style check)
  • disable merge-commit (no merge from master before tests)
  • disable CI cache (job reuse)

Only specified batches in multi-batch jobs:

  • 1
  • 2
  • 3
  • 4

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Mar 26, 2024
@robot-clickhouse-ci-1
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-1 commented Mar 26, 2024 •
edited by robot-ch-test-poll2
Loading

This is an automated comment for commit 14c60de with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Docs checkBuilds and tests the documentation✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success

@evillique evillique self-assigned this Mar 26, 2024
@kssenii
Copy link
Copy Markdown
Member Author

kssenii commented Mar 26, 2024

Integration tests (release) [1/4] — fail: 1

test_runtime_configurable_cache_size/test.py::test_query_cache_size_is_runtime_configurable

@kssenii kssenii merged commit 63dceeb into master Mar 26, 2024
@kssenii kssenii deleted the fix-flaky-test-broke-projections branch March 26, 2024 15:09
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 26, 2024
@CheSema CheSema mentioned this pull request Jul 15, 2024
Merged
19 tasks
@nikitamikhaylov nikitamikhaylov mentioned this pull request Jul 21, 2024
Closed
azat added a commit to azat/ClickHouse that referenced this pull request Feb 17, 2025
@azat
Fix errors and flakiness in test_broken_projections
1b67b21 
Recently CI found one more failure for
test_broken_projections/test.py::test_broken_ignored_replicated [1], but
this time, we have more details:

    Looked for query id , but to no avail: 408ff27f-4d8d-4328-8099-c89c4aeee8ce	SELECT queryID() FROM (SELECT c FROM \'test3_replica\' WHERE d == 12 ORDER BY c SETTINGS force_optimize_projection_name = \'proj1\')	proj1

                      ^^^ - query_id is empty!

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=75973&sha=bb72b6d9b56327982e2366d962be00888790bdb9&name_0=PR&name_1=Integration%20tests%20%28aarch64%2C%202%2F4%29

So:
- flakiness is due to buggy queryID() function, so revet ClickHouse#61932, the issue with queryID() will be fixed separately
- errors due to query included into the "res" so it always match
azat added a commit to azat/ClickHouse that referenced this pull request Feb 17, 2025
@azat
Fix errors and flakiness in test_broken_projections
7b34cc2 
Recently CI found one more failure for
test_broken_projections/test.py::test_broken_ignored_replicated [1], but
this time, we have more details:

    Looked for query id , but to no avail: 408ff27f-4d8d-4328-8099-c89c4aeee8ce	SELECT queryID() FROM (SELECT c FROM \'test3_replica\' WHERE d == 12 ORDER BY c SETTINGS force_optimize_projection_name = \'proj1\')	proj1

                      ^^^ - query_id is empty!

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=75973&sha=bb72b6d9b56327982e2366d962be00888790bdb9&name_0=PR&name_1=Integration%20tests%20%28aarch64%2C%202%2F4%29

So:
- flakiness is due to buggy queryID() function, so revet ClickHouse#61932
  (retrying querying query_log), the issue with queryID() will be fixed
  separately
- errors due to query included into the "res" so it always match
@azat azat mentioned this pull request Feb 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evillique evillique evillique approved these changes

Assignees

@evillique evillique

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kssenii @robot-clickhouse-ci-1 @evillique @robot-ch-test-poll