Improve JSONEachRow reading by ignoring the keys case by KevinyhZou · Pull Request #61750 · ClickHouse/ClickHouse

KevinyhZou · 2024-03-22T07:38:28Z

Changelog category (leave one):

Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Allow matching column names in a case insensitive manner when reading json files (input_format_json_case_insensitive_column_matching).

So we introduce a config to ignore the case problem in such situation.

Documentation entry for user-facing changes

Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

Modify your CI run:

NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Set desired options before CI starts or re-push after updates

Run only:

CI options:

do not test (only style check)
disable merge-commit (no merge from master before tests)
disable CI cache (job reuse)

Only specified batches in multi-batch jobs:

1
2
3
4

robot-clickhouse · 2024-03-22T13:51:13Z

This is an automated comment for commit 0990a82 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check name	Description	Status
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	❌ failure
Cloud fork sync (only for ClickHouse Inc. employees)	If it fails, ask a maintainer for help	⏳ pending
Mergeable Check	Checks if all other necessary checks are successful	⏳ pending
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	❌ failure
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	❌ failure

Successful checks

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	✅ success
ClickBench	Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table	✅ success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker keeper image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docker server image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docs check	Builds and tests the documentation	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	✅ success
PR Check	Checks correctness of the PR's body	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

src/Processors/Formats/Impl/JSONEachRowRowInputFormat.cpp

src/Processors/Formats/Impl/JSONEachRowRowInputFormat.h

alexey-milovidov · 2024-03-26T01:01:23Z

I like the idea, but I'd prefer a few things differently:

It should apply to all data formats with names, such as CSVWithNames, Protobuf, Avro, Parquet, and even Native.
The modes should be: match case, ignore case, and auto. The auto mode will search for a matching column case insensitive if the direct match isn't found. In contrast, the case insensitive mode should throw an exception if the data contain ambiguous names. We will use the "auto" mode by default.

src/Core/Settings.h

tests/queries/0_stateless/02995_baseline_23_12_1.tsv

KevinyhZou · 2024-03-26T11:52:00Z

done @Avogar

KevinyhZou · 2024-03-29T01:53:52Z

Could this pr be merged ? and support for other formats and modes can be later @divanik @alexey-milovidov

alexey-milovidov · 2024-04-03T05:09:16Z

It does not build, and the tests don't pass.
If it's not your tests that have failed, you should either help fix them or wait while they are fixed.

Could this pr be merged ? and support for other formats and modes can be later

Not later. The code should be complete and consistent. The user experience should be flawless.

KevinyhZou · 2024-04-03T06:37:48Z

OK

clickhouse-gh · 2024-06-25T16:51:54Z

Dear @divanik, this PR hasn't been updated for a while. You will be unassigned. Will you continue working on it? If so, please feel free to reassign yourself.

alexey-milovidov · 2024-06-26T01:28:06Z

This is a good change - please resolve conflicts and merge.

al13n321 · 2024-06-27T23:38:10Z

Test failures look unrelated:

01158_zookeeper_log_long - flaky [1]
02931_rewrite_sum_column_and_constant - Fix 02931_rewrite_sum_column_and_constant flakiness #65800
performance comparison - shows lots of weird errors, it does that often these days, didn't investigate

[1] https://play.clickhouse.com/play?user=play#U0VMRUNUIGNoZWNrX3N0YXJ0X3RpbWUsIGNoZWNrX25hbWUsIHRlc3RfbmFtZSwgcHVsbF9yZXF1ZXN0X251bWJlciwgcmVwb3J0X3VybApGUk9NIGNoZWNrcwpXSEVSRSAxCiAgICBBTkQgY2hlY2tfc3RhcnRfdGltZSA+PSBub3coKSAtIElOVEVSVkFMIDcgZGF5CiAgICBBTkQgdGVzdF9zdGF0dXMgIT0gJ1NLSVBQRUQnCiAgICBBTkQgdGVzdF9zdGF0dXMgTElLRSAnRiUnCiAgICBBTkQgY2hlY2tfc3RhdHVzICE9ICdzdWNjZXNzJwogICAgYW5kIHRlc3RfbmFtZSBsaWtlICclMDExNThfem9va2VlcGVyX2xvZ19sb25nJScKT1JERVIgQlkgYWxs

Algunenano · 2024-07-01T18:08:13Z

src/Core/SettingsChangesHistory.h

              {"output_format_csv_serialize_tuple_into_separate_columns", true, true, "A new way of how interpret tuples in CSV format was added."},
              {"input_format_csv_deserialize_separate_columns_into_tuple", true, true, "A new way of how interpret tuples in CSV format was added."},
              {"input_format_csv_try_infer_strings_from_quoted_tuples", true, true, "A new way of how interpret tuples in CSV format was added."},
+              {"input_format_json_ignore_key_case", false, false, "Ignore json key case while read json field from string."},


This should be 24.7

What changes were proposed in this pull request? (Please fill in changes proposed in this fix) (Fixes: #6262) this pr is depend on clickhouse pr: ClickHouse/ClickHouse#61750 How was this patch tested? test by ut

alexey-milovidov · 2024-07-30T09:35:48Z

It is implemented not like we needed. Let's revert.

alexey-milovidov · 2024-07-30T09:38:17Z

src/Processors/Formats/Impl/JSONEachRowRowInputFormat.h

    Block::NameMap name_map;
-
+    /// Hash table match `lower_case field name -> field name in the block`.
+    std::unordered_map<String, StringRef> lower_case_name_map;


This is very bad.

alexey-milovidov · 2024-07-30T09:38:31Z

src/Processors/Formats/Impl/JSONEachRowRowInputFormat.h

+    {
+        String field_name_str = field_name.toString();
+        std::transform(field_name_str.begin(), field_name_str.end(), field_name_str.begin(),
+            [](unsigned char c) { return std::tolower(c); });


This is wrong.

alexey-milovidov · 2024-07-30T09:40:38Z

This will be reverted, because the review is not addressed: #61750 (comment)

…ow_ignore_key_case" This reverts commit 3229cb5, reversing changes made to f838c25.

Revert #61750 "Improve JSONEachRow reading by ignoring the keys case"

… due to ClickHouse/ClickHouse#67484 revert ClickHouse/ClickHouse#61750 This reverts commit 2be6c86.

* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240808) * Fix build due to ClickHouse/ClickHouse#66279 * Revert "[GLUTEN-6262][CH]Json input format ignore key case #6263" due to ClickHouse/ClickHouse#67484 revert ClickHouse/ClickHouse#61750 This reverts commit 2be6c86. * fix gtest due to #6722 --------- Co-authored-by: kyligence-git <[email protected]> Co-authored-by: Chang Chen <[email protected]>

KevinyhZou · 2024-08-08T12:42:08Z

would you open another pr to slove this problem? @alexey-milovidov

alexey-milovidov · 2024-08-08T17:19:42Z

We should do it, but I didn't plan it for the next days. It will be very helpful if you resumbit.

alexey-milovidov added the can be tested Allows running workflows for external contributors label Mar 22, 2024

robot-clickhouse added the pr-improvement Pull request with some product improvements label Mar 22, 2024

divanik self-requested a review March 22, 2024 17:19

divanik requested changes Mar 22, 2024

View reviewed changes

src/Processors/Formats/Impl/JSONEachRowRowInputFormat.cpp Outdated Show resolved Hide resolved

src/Processors/Formats/Impl/JSONEachRowRowInputFormat.h Outdated Show resolved Hide resolved

KevinyhZou force-pushed the improve_json_each_row_ignore_key_case branch from 7159bec to 37f028d Compare March 25, 2024 10:08

divanik self-requested a review March 25, 2024 10:11

divanik approved these changes Mar 25, 2024

View reviewed changes

alexey-milovidov assigned divanik Mar 26, 2024

alexey-milovidov changed the title ~~Improve json earch row read by ignore key case~~ Improve JSONEachRow reading by ignoring the keys case Mar 26, 2024

Avogar reviewed Mar 26, 2024

View reviewed changes

src/Core/Settings.h Outdated Show resolved Hide resolved

Avogar reviewed Mar 26, 2024

View reviewed changes

tests/queries/0_stateless/02995_baseline_23_12_1.tsv Outdated Show resolved Hide resolved

KevinyhZou force-pushed the improve_json_each_row_ignore_key_case branch from 39949fa to 93de14c Compare March 29, 2024 01:51

KevinyhZou added 5 commits April 25, 2024 12:21

Improve json read by ignore key case

7c9dbdb

ci fix

3c6c40f

ci fix

bb6520e

review fix

fde8008

Fix build problem

70d6a62

KevinyhZou force-pushed the improve_json_each_row_ignore_key_case branch from ef86407 to 70d6a62 Compare April 25, 2024 06:07

check style

dffa4d6

clickhouse-gh bot unassigned divanik Jun 25, 2024

Merge branch 'master' into improve_json_each_row_ignore_key_case

0990a82

al13n321 added this pull request to the merge queue Jun 27, 2024

Merged via the queue into ClickHouse:master with commit 3229cb5 Jun 28, 2024

robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Jun 28, 2024

KevinyhZou mentioned this pull request Jun 28, 2024

[GLUTEN-6262][CH]Json input format ignore key case apache/gluten#6263

Merged

KevinyhZou deleted the improve_json_each_row_ignore_key_case branch June 28, 2024 02:12

Algunenano reviewed Jul 1, 2024

View reviewed changes

Algunenano mentioned this pull request Jul 1, 2024

Fix SettingsChangesHistory 24.7 #65945

Merged

alexey-milovidov assigned al13n321 Jul 30, 2024

alexey-milovidov reviewed Jul 30, 2024

View reviewed changes

al13n321 added a commit that referenced this pull request Jul 30, 2024

Revert "Merge pull request #61750 from KevinyhZou/improve_json_each_r…

07291cb

…ow_ignore_key_case" This reverts commit 3229cb5, reversing changes made to f838c25.

al13n321 mentioned this pull request Jul 30, 2024

Revert #61750 "Improve JSONEachRow reading by ignoring the keys case" #67484

Merged

github-merge-queue bot pushed a commit that referenced this pull request Aug 6, 2024

Merge pull request #67484 from ClickHouse/nojs

dc776af

Revert #61750 "Improve JSONEachRow reading by ignoring the keys case"

baibaichen added a commit to Kyligence/gluten that referenced this pull request Aug 8, 2024

Revert "[GLUTEN-6262][CH]Json input format ignore key case apache#6263"…

3d2ed3b

… due to ClickHouse/ClickHouse#67484 revert ClickHouse/ClickHouse#61750 This reverts commit 2be6c86.

baibaichen added a commit to Kyligence/gluten that referenced this pull request Aug 8, 2024

Revert "[GLUTEN-6262][CH]Json input format ignore key case apache#6263"…

2591a60

… due to ClickHouse/ClickHouse#67484 revert ClickHouse/ClickHouse#61750 This reverts commit 2be6c86.

baibaichen mentioned this pull request Aug 8, 2024

[CH] JSON input format can not parse while key's case not match apache/gluten#6262

Open

alexey-milovidov mentioned this pull request Dec 22, 2025

For input formats with column names, search columns case-insensitively if there is no ambiguity #92851

Open

Conversation

KevinyhZou commented Mar 22, 2024 • edited by Algunenano Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Documentation entry for user-facing changes

Modify your CI run:

Run only:

CI options:

Only specified batches in multi-batch jobs:

Uh oh!

robot-clickhouse commented Mar 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexey-milovidov commented Mar 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KevinyhZou commented Mar 26, 2024

Uh oh!

KevinyhZou commented Mar 29, 2024

Uh oh!

alexey-milovidov commented Apr 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KevinyhZou commented Apr 3, 2024

Uh oh!

clickhouse-gh bot commented Jun 25, 2024

Uh oh!

alexey-milovidov commented Jun 26, 2024

Uh oh!

al13n321 commented Jun 27, 2024

Uh oh!

Algunenano Jul 1, 2024

Choose a reason for hiding this comment

Uh oh!

alexey-milovidov commented Jul 30, 2024

Uh oh!

alexey-milovidov Jul 30, 2024

Choose a reason for hiding this comment

Uh oh!

alexey-milovidov Jul 30, 2024

Choose a reason for hiding this comment

Uh oh!

alexey-milovidov commented Jul 30, 2024

Uh oh!

KevinyhZou commented Aug 8, 2024

Uh oh!

alexey-milovidov commented Aug 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

KevinyhZou commented Mar 22, 2024 •

edited by Algunenano

Loading

robot-clickhouse commented Mar 22, 2024 •

edited

Loading

alexey-milovidov commented Mar 26, 2024 •

edited

Loading

alexey-milovidov commented Apr 3, 2024 •

edited

Loading