Skip to content

Fix test test_system_clusters_actual_information flakiness#61395

Merged
Avogar merged 2 commits intoClickHouse:masterfrom
Avogar:fox-test-clusters-actual-information
Mar 15, 2024
Merged

Fix test test_system_clusters_actual_information flakiness#61395
Avogar merged 2 commits intoClickHouse:masterfrom
Avogar:fox-test-clusters-actual-information

Conversation

@Avogar
Copy link
Copy Markdown
Member

@Avogar Avogar commented Mar 14, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Closes #55168

@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Mar 14, 2024
@robot-ch-test-poll4
Copy link
Copy Markdown
Contributor

robot-ch-test-poll4 commented Mar 14, 2024 •
edited by robot-clickhouse-ci-2
Loading

This is an automated comment for commit e8da3bb with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@Avogar Avogar changed the title Test test test_system_clusters_actual_information flakiness Fix test test_system_clusters_actual_information flakiness Mar 14, 2024
@nikitamikhaylov
Copy link
Copy Markdown
Member

nikitamikhaylov commented Mar 14, 2024

This is a duplicate of #61375 and this PR looks quite radical... I'm not sure, looks like you were the initial author of the test, so I will let you to decide.

@Avogar
Copy link
Copy Markdown
Member Author

Avogar commented Mar 14, 2024

It's actually not needed to create node_1 at all, and removing it will fix any possible flakiness of this test without any impact on the test logic

@Avogar Avogar mentioned this pull request Mar 14, 2024
Closed
@antaljanosbenjamin antaljanosbenjamin self-assigned this Mar 15, 2024
@Avogar Avogar merged commit fef38bd into ClickHouse:master Mar 15, 2024
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antaljanosbenjamin antaljanosbenjamin antaljanosbenjamin approved these changes

Assignees

@antaljanosbenjamin antaljanosbenjamin

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flaky test_system_clusters_actual_information

5 participants

@Avogar @robot-ch-test-poll4 @nikitamikhaylov @antaljanosbenjamin @robot-ch-test-poll1