Skip to content

Add retries to 02908_many_requests_to_system_replicas#61253

Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
nickitat:02908_many_requests
Mar 13, 2024
Merged

Add retries to 02908_many_requests_to_system_replicas#61253
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
nickitat:02908_many_requests

Conversation

@nickitat
Copy link
Copy Markdown
Member

@nickitat nickitat commented Mar 12, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Often errors look the following:

2024-03-10 18:52:04 --- /usr/share/clickhouse-test/queries/0_stateless/02908_many_requests_to_system_replicas.reference	2024-03-10 18:33:34.651733404 +0500
2024-03-10 18:52:04 +++ /tmp/clickhouse-test/0_stateless/02908_many_requests_to_system_replicas.stdout	2024-03-10 18:51:53.215842065 +0500
2024-03-10 18:52:04 @@ -1,5 +1,7 @@
2024-03-10 18:52:04  Creating 300 tables
2024-03-10 18:52:04 +curl: (56) Recv failure: Connection reset by peer
2024-03-10 18:52:04 +curl: (56) Recv failure: Connection reset by peer
2024-03-10 18:52:04  Making 200 requests to system.replicas
2024-03-10 18:52:04  Query system.replicas while waiting for other concurrent requests to finish
2024-03-10 18:52:04  0
2024-03-10 18:52:04 -900
2024-03-10 18:52:04 +898

so we're getting errors from curl during tables creation. I think some retries there wouldn't harm.

Fixes #57443

@robot-ch-test-poll robot-ch-test-poll added the pr-not-for-changelog This PR should not be mentioned in the changelog label Mar 12, 2024
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented Mar 12, 2024 •
edited by robot-clickhouse
Loading

This is an automated comment for commit 24f4cda with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure

@serxa serxa self-assigned this Mar 12, 2024
@alexey-milovidov alexey-milovidov merged commit 3bf267e into ClickHouse:master Mar 13, 2024
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 13, 2024
@azat azat mentioned this pull request Mar 19, 2024
Merged
@azat
Copy link
Copy Markdown
Member

azat commented Mar 19, 2024

Looks like this did not help completely - https://s3.amazonaws.com/clickhouse-test-reports/61399/8b77f4e89366613733fe53ad9904c7137983fa31/stateless_tests__asan__[1_4].html

@nickitat
Copy link
Copy Markdown
Member Author

nickitat commented Mar 19, 2024

Looks like this did not help completely - https://s3.amazonaws.com/clickhouse-test-reports/61399/8b77f4e89366613733fe53ad9904c7137983fa31/stateless_tests__asan__[1_4].html

another attempt: #61616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serxa serxa serxa approved these changes

Assignees

@serxa serxa

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

02908_many_requests_to_system_replicas is flaky

6 participants

@nickitat @robot-ch-test-poll @azat @serxa @alexey-milovidov @robot-clickhouse