Skip to content

Fix "Invalid storage definition in metadata file" for parameterized views#60708

Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
azat:fix-invalid-storage-metadata-error
Mar 3, 2024
Merged

Fix "Invalid storage definition in metadata file" for parameterized views#60708
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
azat:fix-invalid-storage-metadata-error

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Mar 3, 2024 •
edited
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix "Invalid storage definition in metadata file" for parameterized views

Fixes: #60349

@azat azat changed the title Fix "Invalid storage definition in metadata file" for parametrized views Fix "Invalid storage definition in metadata file" for parameterized views Mar 3, 2024
@azat azat force-pushed the fix-invalid-storage-metadata-error branch from 24e373a to eb711bd Compare March 3, 2024 15:02
@azat azat mentioned this pull request Mar 3, 2024
Merged
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-bugfix Pull request with bugfix, not backported by default label Mar 3, 2024
@robot-clickhouse-ci-1
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-1 commented Mar 3, 2024 •
edited by robot-ch-test-poll2
Loading

This is an automated comment for commit eb711bd with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure

@alexey-milovidov alexey-milovidov self-assigned this Mar 3, 2024
@alexey-milovidov alexey-milovidov merged commit fa72431 into ClickHouse:master Mar 3, 2024
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 3, 2024
@azat azat deleted the fix-invalid-storage-metadata-error branch March 3, 2024 19:06
@tavplubix tavplubix mentioned this pull request Mar 15, 2024
Closed
@oleg-savko
Copy link
Copy Markdown

oleg-savko commented May 16, 2024

can it be backported to v24.2, please?

@alexey-milovidov alexey-milovidov added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label May 17, 2024
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 mentioned this pull request May 17, 2024
Merged
robot-clickhouse added a commit that referenced this pull request May 17, 2024
@robot-clickhouse
Backport #60708 to 23.8: Fix "Invalid storage definition in metadata …
cede195 
…file" for parameterized views
This was referenced May 17, 2024
Merged
Merged
robot-clickhouse added a commit that referenced this pull request May 17, 2024
@robot-clickhouse
Backport #60708 to 24.2: Fix "Invalid storage definition in metadata …
3f6103b 
…file" for parameterized views
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 mentioned this pull request May 17, 2024
Merged
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label May 17, 2024
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-backports-created-cloud deprecated label, NOOP label May 17, 2024
robot-ch-test-poll4 added a commit that referenced this pull request May 17, 2024
@robot-ch-test-poll4
Merge pull request #64018 from ClickHouse/backport/24.2/60708
bbe0841 
Backport #60708 to 24.2: Fix "Invalid storage definition in metadata file" for parameterized views
alexey-milovidov added a commit that referenced this pull request May 18, 2024
@alexey-milovidov
Merge pull request #64016 from ClickHouse/backport/23.8/60708
65d4535 
Backport #60708 to 23.8: Fix "Invalid storage definition in metadata file" for parameterized views
@aalexfvk aalexfvk mentioned this pull request Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Logical error: Invalid storage definition in metadata file: it's a bug or result of manual intervention in metadata files

6 participants

@azat @robot-clickhouse-ci-1 @oleg-savko @alexey-milovidov @robot-clickhouse @robot-ch-test-poll2