Skip to content

Remove useless virtual func call in ColumnNullable#60556

Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
HappenLee:master
Jun 14, 2024
Merged

Remove useless virtual func call in ColumnNullable#60556
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
HappenLee:master

Conversation

@HappenLee
Copy link
Copy Markdown
Contributor

@HappenLee HappenLee commented Feb 29, 2024 •
edited by Algunenano
Loading

Changelog category (leave one):

  • Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Reduce the number of virtual function calls in ColumnNullable::size()

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Feb 29, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@nickitat nickitat self-assigned this Feb 29, 2024
@nickitat nickitat changed the title Reduce unless virtual func call in ColumnNullable Remove useless virtual func call in ColumnNullable Feb 29, 2024
@clickhouse-ci
Copy link
Copy Markdown

clickhouse-ci bot commented Feb 29, 2024

This is an automatic comment. The PR descriptions does not match the template.

Please, edit it accordingly.

The error is: Changelog entry required for category 'Performance Improvement'

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-performance Pull request with some performance improvements label Feb 29, 2024
@robot-clickhouse-ci-1
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-1 commented Feb 29, 2024 •
edited by robot-clickhouse
Loading

This is an automated comment for commit f976ee0 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure

@nickitat nickitat added the can be tested Allows running workflows for external contributors label Mar 27, 2024
@alexey-milovidov alexey-milovidov added this pull request to the merge queue Jun 14, 2024
@alexey-milovidov alexey-milovidov self-assigned this Jun 14, 2024
Merged via the queue into ClickHouse:master with commit efb31c1 Jun 14, 2024
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jun 14, 2024
baibaichen added a commit to Kyligence/gluten that referenced this pull request Jun 15, 2024
@baibaichen
Fix build due to ClickHouse/ClickHouse#60556
c0de850
baibaichen added a commit to Kyligence/gluten that referenced this pull request Jun 15, 2024
@baibaichen
Fix build due to ClickHouse/ClickHouse#60556
bf4d291
baibaichen added a commit to apache/gluten that referenced this pull request Jun 16, 2024
@kyligence-git @baibaichen
[GLUTEN-1632][CH]Daily Update Clickhouse Version (20240616) (#6100)
a08a57c 
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240616)

* Fix Build due to ClickHouse/ClickHouse#64412

* Fix UT due to ClickHouse/ClickHouse#64986

* Fix build due to ClickHouse/ClickHouse#60556

* Ignore TPCH Q17 which include avg

* Fix 'Invalid Field get from type Decimal64 to type Int64' in debug build.

---------

Co-authored-by: kyligence-git <[email protected]>
Co-authored-by: Chang Chen <[email protected]>
@Avogar Avogar mentioned this pull request Jun 17, 2024
Closed
@Avogar
Copy link
Copy Markdown
Member

Avogar commented Jun 17, 2024

Seems like this PR somehow broke test 03036_dynamic_read_subcolumns. Let's revert. I will investigate the reason later and reintroduce this PR.

@Avogar Avogar mentioned this pull request Jun 17, 2024
Merged
19 tasks
@Avogar
Copy link
Copy Markdown
Member

Avogar commented Jun 17, 2024 •
edited
Loading

UPD: I found the reason of the crash in this test, the fix is easy, so let's not revert and merge the fix: #65341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickitat nickitat nickitat approved these changes

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

can be tested Allows running workflows for external contributors pr-performance Pull request with some performance improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@HappenLee @CLAassistant @robot-clickhouse-ci-1 @Avogar @nickitat @alexey-milovidov @robot-ch-test-poll1