Enable testing with io_uring back#60383
Conversation
|
This is an automated comment for commit 2534750 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
|
according to docs, another quote from io_uring_setup: based on that I just want to try a privileged container. |
|
On one hand, On the other, let's then try using the more specific |
29616a3 to
962157d
Compare
io_uring back
962157d to
eda54d3
Compare
src/Storages/StorageFile.cpp
Outdated
There was a problem hiding this comment.
Why storage_file_read_method=io_uring supported had been reverted?
There was a problem hiding this comment.
because I wanted to quickly test the fix
tests/clickhouse-test
Outdated
There was a problem hiding this comment.
Instead of reverting this, maybe it is better to add a test with explicit io_uring method requested?
|
|
2294e8a to
7212206
Compare
|
for some reason test ❯ sudo docker run --privileged -v ./build/programs/clickhouse:/clickhouse clickhouse/stateless-test:238cad023c02 /clickhouse local --profile-events-delay-ms=-1 --print-profile-events -q "SELECT * FROM file('/etc/hosts', 'LineAsString') FORMAT Null" |& grep -m1 -F -o -e OSReadChars && echo OK || echo FAILED
FAILED
❯ sudo docker run --security-opt seccomp=unconfined -v ./build/programs/clickhouse:/clickhouse clickhouse/stateless-test:238cad023c02 /clickhouse local --profile-events-delay-ms=-1 --print-profile-events -q "SELECT * FROM file('/etc/hosts', 'LineAsString') FORMAT Null" |& grep -m1 -F -o -e OSReadChars && echo OK || echo FAILED
OSReadChars
OK |
7212206 to
27923ee
Compare
|
No backport, please. We are not interested in io_uring in releases. |
Changelog category (leave one):