Skip to content

Enable testing with io_uring back#60383

Merged
Felixoid merged 4 commits intoClickHouse:masterfrom
nickitat:upd_liburing
Mar 5, 2024
Merged

Enable testing with io_uring back#60383
Felixoid merged 4 commits intoClickHouse:masterfrom
nickitat:upd_liburing

Conversation

@nickitat
Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

…_uring"

This reverts commit 648e6ec, reversing
changes made to 273b483.
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR. labels Feb 25, 2024
@robot-clickhouse-ci-2
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-2 commented Feb 25, 2024

This is an automated comment for commit 2534750 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure

@nickitat
Copy link
Copy Markdown
Member Author

nickitat commented Feb 25, 2024

according to docs, io_uring_queue_init returns -errno, so the error it gives back seems to be EPERM (=1).
sounds familiar: https://stackoverflow.com/questions/71075245/io-uring-queue-init-permission-denied

another quote from io_uring_setup:

       EPERM  /proc/sys/kernel/io_uring_disabled has the value 2, or it
              has the value 1 and the calling process does not hold the
              CAP_SYS_ADMIN capability or is not a member of
              /proc/sys/kernel/io_uring_group.

based on that I just want to try a privileged container.

@Felixoid
Copy link
Copy Markdown
Member

On one hand, --privileged is a solution to many issues.

On the other, let's then try using the more specific --cap-add=SYS_ADMIN

@nickitat nickitat force-pushed the upd_liburing branch 2 times, most recently from 29616a3 to 962157d Compare February 26, 2024 12:50
@robot-ch-test-poll4 robot-ch-test-poll4 removed the submodule changed At least one submodule changed in this PR. label Feb 26, 2024
@nickitat nickitat changed the title Just in case test with slightly newer liburing Enable testing with io_uring back Feb 26, 2024
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why storage_file_read_method=io_uring supported had been reverted?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because I wanted to quickly test the fix

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of reverting this, maybe it is better to add a test with explicit io_uring method requested?

@azat
Copy link
Copy Markdown
Member

azat commented Feb 26, 2024

SYS_ADMIN will not help because AFAIR only --privileged disables all SELinux policies. So something like this may work --security-opt label:disable I guess (though I haven't tried)

@nickitat nickitat marked this pull request as ready for review February 28, 2024 18:08
@nickitat
Copy link
Copy Markdown
Member Author

for some reason test 01268_procfs_metrics breaks with --privileged. will try to use unconfined instead.

❯ sudo docker run --privileged -v ./build/programs/clickhouse:/clickhouse clickhouse/stateless-test:238cad023c02 /clickhouse local --profile-events-delay-ms=-1 --print-profile-events -q "SELECT * FROM file('/etc/hosts', 'LineAsString') FORMAT Null" |& grep -m1 -F -o -e OSReadChars && echo OK || echo FAILED
FAILED
❯ sudo docker run --security-opt seccomp=unconfined -v ./build/programs/clickhouse:/clickhouse clickhouse/stateless-test:238cad023c02 /clickhouse local --profile-events-delay-ms=-1 --print-profile-events -q "SELECT * FROM file('/etc/hosts', 'LineAsString') FORMAT Null" |& grep -m1 -F -o -e OSReadChars && echo OK || echo FAILED
OSReadChars
OK

@nickitat
Copy link
Copy Markdown
Member Author

nickitat commented Mar 1, 2024

Stateless tests (msan) [5/6] - #60627
Stateless tests (ubsan) [1/2] - #60627
Stress test (debug) - #60349
Stress test (tsan) - #60349

@Felixoid Felixoid added pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Mar 5, 2024
@Felixoid Felixoid self-assigned this Mar 5, 2024
@Felixoid Felixoid merged commit ec72800 into ClickHouse:master Mar 5, 2024
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 5, 2024
@alexey-milovidov
Copy link
Copy Markdown
Member

No backport, please. We are not interested in io_uring in releases.

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Mar 5, 2024
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-backports-created-cloud deprecated label, NOOP label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants