Detect io_uring in tests by azat · Pull Request #60373 · ClickHouse/ClickHouse

azat · 2024-02-24T18:18:37Z

Changelog category (leave one):

Not for changelog (changelog entry is not required)

Sometimes CI may not have it - https://s3.amazonaws.com/clickhouse-test-reports/60153/ef4a9e8ff99848a5c9e9f7336af24eb5ec259c18/stateless_tests__tsan__[2_5].html

robot-clickhouse-ci-1 · 2024-02-24T18:21:20Z

This is an automated comment for commit 554d993 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks

Check name	Description	Status
ClickBench	Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table	✅ success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker keeper image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docker server image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docs check	Builds and tests the documentation	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
SQLTest	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
SQLancer	Fuzzing tests that detect logical bugs with SQLancer tool	✅ success
Sqllogic	Run clickhouse on the sqllogic test set against sqlite and checks that all statements are passed	✅ success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

Check name	Description	Status
A Sync	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	❌ failure
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	❌ failure
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	⏳ pending
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	❌ failure
Mergeable Check	Checks if all other necessary checks are successful	❌ failure
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	❌ failure
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	❌ failure

Signed-off-by: Azat Khuzhin <[email protected]>

alexey-milovidov · 2024-02-25T12:23:44Z

@azat We updated to the new AMI in AWS, which does not enable uring by default.
We should either find a way to enable it (probably with some sysctl), or remove uring from the codebase as we lose the way to test it, and every untested feature is the same as nonexistent.

Felixoid · 2024-02-25T13:25:11Z

The AMI is deployed in #60316

I've spun a test on some fresh host, and here's the result:

$ curl -O https://s3.amazonaws.com/clickhouse-builds/24.2/32607cc7967712890d6dd53cf82a409876bcf459/package_tsan/clickhouse -s
$ chmod +x clickhouse && ./clickhouse local -q "select * from file('/dev/null', 'LineAsString')" --storage_file_read_method io_uring
Decompressing the binary.....................
$ echo $?
0

I am not sure if the AMI is a reason here.

Felixoid · 2024-02-25T13:35:10Z

For example, here's the failing test https://s3.amazonaws.com/clickhouse-test-reports/0/f70d4d9372e02790c7c585a41862b70efc0b6fd4/stateless_tests__tsan__[1_5].html

I open the job and see the machine type m6i.4xlarge. And the host with the same type works.

I run then the same in the same container

$ docker run -v ~/clickhouse:/clickhouse clickhouse/stateless-test:238cad023c02 /clickhouse local -q "select * from file('/dev/null', 'LineAsString')" --storage_file_read_method io_uring && echo OK || echo FAILED
OK

It's very strange, and I am open to ideas

…_uring" This reverts commit 648e6ec, reversing changes made to 273b483.

nickitat · 2024-02-25T14:23:37Z

what are the chances that we're getting a kernel < 5.6?)
I found this code in lib tests: axboe/liburing@3508db9

Felixoid · 2024-02-25T16:24:56Z

what are the chances that we're getting a kernel < 5.6?) I found this code in lib tests: axboe/liburing@3508db9

I'd say 0.00000...1%

# arm64 host
$ uname -a
Linux ip-172-31-3-162 6.5.0-1014-aws #14~22.04.1-Ubuntu SMP Thu Feb 15 19:20:45 UTC 2024 aarch64 aarch64 aarch64 GNU/Linux
# x86_64 host
$ uname -a
Linux ip-172-31-10-141 6.5.0-1014-aws #14~22.04.1-Ubuntu SMP Thu Feb 15 15:27:06 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

nickitat · 2024-02-25T23:56:21Z

I'm not 100% sure since not all checks are finished, but seems to work: #60383 (comment)

Felixoid · 2024-02-26T09:46:18Z

Hmm, in the old AMI there's an older kernel

$ uname -a
Linux ip-172-31-45-130 6.2.0-1015-aws #15~22.04.1-Ubuntu SMP Fri Oct  6 23:21:18 UTC 2023 aarch64 aarch64 aarch64 GNU/Linux

azat · 2024-02-26T21:04:08Z

$ curl -O https://s3.amazonaws.com/clickhouse-builds/24.2/32607cc7967712890d6dd53cf82a409876bcf459/package_tsan/clickhouse -s
$ chmod +x clickhouse && ./clickhouse local -q "select * from file('/dev/null', 'LineAsString')" --storage_file_read_method io_uring

@Felixoid this does not work without this PR

Felixoid · 2024-02-26T23:03:52Z

What I've tried to show is that I can't reproduce the issue, unfortunately

azat · 2024-02-27T07:08:30Z

Indeed, because you were trying binary without this PR, while this PR two things:

storage_file_read_method=io_uring for clickhouse-local
detection of io_uring via this in clickhouse-test

Felixoid · 2024-02-27T08:56:00Z

Here we go. Compare current version 25.0.3 to 24.0.7. Docker removed the io_uring from the default allowed syscalls

Felixoid · 2024-02-27T09:00:54Z

And that's what works:

ubuntu@ip-172-31-70-76:~$ curl -O https://s3.amazonaws.com/clickhouse-builds/24.2/648e6ec5a63f777c5c44405d45574aaebf77142b/package_release/clickhouse -s
ubuntu@ip-172-31-70-76:~$ chmod +x clickhouse && ./clickhouse local -q "select * from file('/dev/null', 'LineAsString')" --storage_file_read_method io_uring
Decompressing the binary.................
ubuntu@ip-172-31-70-76:~$ echo $?
0
ubuntu@ip-172-31-70-76:~$ docker run --security-opt seccomp=unconfined -v ~/clickhouse:/clickhouse clickhouse/stateless-test:238cad023c02 /clickhouse local -q "select * from file('/dev/null', 'LineAsString')" --storage_file_read_method io_uring && echo OK || echo FAILED
OK
ubuntu@ip-172-31-70-76:~$ docker run -v ~/clickhouse:/clickhouse clickhouse/stateless-test:238cad023c02 /clickhouse local -q "select * from file('/dev/null', 'LineAsString')" --storage_file_read_method io_uring && echo OK || echo FAILED
Code: 1. DB::Exception: io_uring is not supported by this system: While executing File. (UNSUPPORTED_METHOD)
FAILED

Felixoid · 2024-02-27T09:14:05Z

And here's the PR implementing it moby/moby#46762

Algunenano · 2024-03-01T11:52:27Z

I'm going to backport this change to other public releases, as otherwise the CI there is completely broken

Backport #60373 to 24.1: Detect io_uring in tests

Backport #60373 to 23.12: Detect io_uring in tests

Backport #60373 to 23.8: Detect io_uring in tests

Backport #60373 to 23.3: Detect io_uring in tests

azat mentioned this pull request Feb 24, 2024

Enable all access control improvements by default (even without config.xml) #60153

Merged

robot-clickhouse-ci-1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Feb 24, 2024

azat added 3 commits February 24, 2024 19:36

Support io_uring for StorageFile

a70a100

Signed-off-by: Azat Khuzhin <[email protected]>

Detect io_uring in tests

35e948a

Signed-off-by: Azat Khuzhin <[email protected]>

clickhouse-test: fix style check (unused import platform)

554d993

Signed-off-by: Azat Khuzhin <[email protected]>

azat force-pushed the tests/detect-io_uring branch from 7cac803 to 554d993 Compare February 24, 2024 18:37

alexey-milovidov approved these changes Feb 24, 2024

View reviewed changes

alexey-milovidov merged commit 648e6ec into ClickHouse:master Feb 25, 2024

alexey-milovidov self-assigned this Feb 25, 2024

robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Feb 25, 2024

nickitat added a commit to nickitat/ClickHouse that referenced this pull request Feb 25, 2024

Revert "Merge pull request ClickHouse#60373 from azat/tests/detect-io…

3c5d6c4

…_uring" This reverts commit 648e6ec, reversing changes made to 273b483.

nikitamikhaylov added the pr-must-backport-cloud label Feb 26, 2024

jrdi mentioned this pull request Feb 26, 2024

Ulid short circuit #60211

Merged

vdimir mentioned this pull request Feb 26, 2024

Analyzer: compute ALIAS columns right after reading #59595

Merged

1 task

azat deleted the tests/detect-io_uring branch February 26, 2024 21:03

Algunenano added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Mar 1, 2024

robot-clickhouse added a commit that referenced this pull request Mar 1, 2024

Backport #60373 to 23.3: Detect io_uring in tests

81c831d

robot-ch-test-poll2 mentioned this pull request Mar 1, 2024

Backport #60373 to 23.3: Detect io_uring in tests #60645

Merged

robot-clickhouse added a commit that referenced this pull request Mar 1, 2024

Backport #60373 to 23.8: Detect io_uring in tests

5086c64

robot-ch-test-poll2 mentioned this pull request Mar 1, 2024

Backport #60373 to 23.8: Detect io_uring in tests #60646

Merged

robot-clickhouse added a commit that referenced this pull request Mar 1, 2024

Backport #60373 to 23.12: Detect io_uring in tests

5c22076

robot-ch-test-poll2 mentioned this pull request Mar 1, 2024

Backport #60373 to 23.12: Detect io_uring in tests #60647

Merged

robot-clickhouse added a commit that referenced this pull request Mar 1, 2024

Backport #60373 to 24.1: Detect io_uring in tests

a225dfc

robot-ch-test-poll2 mentioned this pull request Mar 1, 2024

Backport #60373 to 24.1: Detect io_uring in tests #60648

Merged

robot-ch-test-poll2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Mar 1, 2024

robot-clickhouse-ci-2 added the pr-backports-created-cloud deprecated label, NOOP label Mar 1, 2024

alexey-milovidov added a commit that referenced this pull request Mar 1, 2024

Merge pull request #60648 from ClickHouse/backport/24.1/60373

93d3f33

Backport #60373 to 24.1: Detect io_uring in tests

alexey-milovidov added a commit that referenced this pull request Mar 1, 2024

Merge pull request #60647 from ClickHouse/backport/23.12/60373

b00fca3

Backport #60373 to 23.12: Detect io_uring in tests

alexey-milovidov added a commit that referenced this pull request Mar 1, 2024

Merge pull request #60646 from ClickHouse/backport/23.8/60373

b6063fd

Backport #60373 to 23.8: Detect io_uring in tests

alexey-milovidov added a commit that referenced this pull request Mar 1, 2024

Merge pull request #60645 from ClickHouse/backport/23.3/60373

6220a88

Backport #60373 to 23.3: Detect io_uring in tests

Conversation

azat commented Feb 24, 2024

Changelog category (leave one):

Uh oh!

robot-clickhouse-ci-1 commented Feb 24, 2024 • edited by robot-clickhouse-ci-2 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexey-milovidov commented Feb 25, 2024

Uh oh!

Felixoid commented Feb 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Felixoid commented Feb 25, 2024

Uh oh!

nickitat commented Feb 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Felixoid commented Feb 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nickitat commented Feb 25, 2024

Uh oh!

Felixoid commented Feb 26, 2024

Uh oh!

azat commented Feb 26, 2024

Uh oh!

Felixoid commented Feb 26, 2024

Uh oh!

azat commented Feb 27, 2024

Uh oh!

Felixoid commented Feb 27, 2024

Uh oh!

Felixoid commented Feb 27, 2024

Uh oh!

Felixoid commented Feb 27, 2024

Uh oh!

Algunenano commented Mar 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

robot-clickhouse-ci-1 commented Feb 24, 2024 •

edited by robot-clickhouse-ci-2

Loading

Felixoid commented Feb 25, 2024 •

edited

Loading

nickitat commented Feb 25, 2024 •

edited

Loading

Felixoid commented Feb 25, 2024 •

edited

Loading