Skip to content

Analyzer: support join using column from select list#60182

Merged
vdimir merged 5 commits intomasterfrom
vdimir/analyzer/join_using_parent_scope
Mar 20, 2024
Merged

Analyzer: support join using column from select list#60182
vdimir merged 5 commits intomasterfrom
vdimir/analyzer/join_using_parent_scope

Conversation

@vdimir
Copy link
Copy Markdown
Member

@vdimir vdimir commented Feb 20, 2024 •
edited
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

This PR is made on top and requires #59595 (required PR is merged)

@vdimir vdimir added the analyzer Issues and pull-requests related to new analyzer label Feb 20, 2024
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Feb 20, 2024
@robot-ch-test-poll2
Copy link
Copy Markdown
Contributor

robot-ch-test-poll2 commented Feb 20, 2024 •
edited by robot-clickhouse-ci-2
Loading

This is an automated comment for commit a8885e3 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process❌ failure
Mergeable CheckChecks if all other necessary checks are successful❌ failure
Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@vdimir vdimir force-pushed the vdimir/analyzer/join_using_parent_scope branch from b4bffff to cab8101 Compare February 22, 2024 12:03
@vdimir vdimir changed the base branch from master to vdimir/analyzer/comute_alias_columns February 22, 2024 12:04
@vdimir vdimir force-pushed the vdimir/analyzer/join_using_parent_scope branch from cab8101 to e8b780a Compare February 22, 2024 12:07
@vdimir vdimir changed the base branch from vdimir/analyzer/comute_alias_columns to master February 22, 2024 12:08
@vdimir vdimir force-pushed the vdimir/analyzer/join_using_parent_scope branch from e8b780a to f8561d4 Compare February 23, 2024 12:32
@vdimir
Copy link
Copy Markdown
Member Author

vdimir commented Feb 23, 2024

Ref #56814

@vdimir vdimir mentioned this pull request Feb 23, 2024
Closed
1 task
@vdimir vdimir force-pushed the vdimir/analyzer/join_using_parent_scope branch 2 times, most recently from 1e9d9df to 41bc85c Compare March 1, 2024 15:48
@vdimir vdimir force-pushed the vdimir/analyzer/join_using_parent_scope branch 5 times, most recently from 5cb7983 to 7521e20 Compare March 13, 2024 15:45
@vdimir vdimir force-pushed the vdimir/analyzer/join_using_parent_scope branch from 7521e20 to 589c784 Compare March 18, 2024 11:12
@vdimir vdimir marked this pull request as ready for review March 19, 2024 11:52
@vdimir vdimir requested a review from novikd March 19, 2024 11:52
@novikd novikd self-assigned this Mar 19, 2024
novikd
novikd approved these changes Mar 19, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@novikd novikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdimir
Copy link
Copy Markdown
Member Author

vdimir commented Mar 20, 2024

ClickHouse special build check — 14/15 artifact groups are OK Details

#61593

@vdimir vdimir merged commit 7ba425a into master Mar 20, 2024
@vdimir vdimir deleted the vdimir/analyzer/join_using_parent_scope branch March 20, 2024 09:59
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 20, 2024
This was referenced Mar 20, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@novikd novikd novikd approved these changes

Assignees

@novikd novikd

Labels

analyzer Issues and pull-requests related to new analyzer pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vdimir @robot-ch-test-poll2 @novikd @robot-ch-test-poll4