Skip to content

Unite s3/hdfs/azure storage implementations into a single class working with IObjectStorage. Same for *Cluster, data lakes and Queue storages.#59767

Merged
kssenii merged 98 commits intomasterfrom
use-iobject-storage-for-table-engines-1
May 25, 2024
Merged

Unite s3/hdfs/azure storage implementations into a single class working with IObjectStorage. Same for *Cluster, data lakes and Queue storages.#59767
kssenii merged 98 commits intomasterfrom
use-iobject-storage-for-table-engines-1

Conversation

@kssenii
Copy link
Copy Markdown
Member

@kssenii kssenii commented Feb 8, 2024 •
edited
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

This will allow to easily add support for any kind of storage for data lakes and for Queue storage engines and allows to get rid of almost copy-paste storage implementations.

@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Feb 8, 2024
@robot-ch-test-poll4
Copy link
Copy Markdown
Contributor

robot-ch-test-poll4 commented Feb 8, 2024 •
edited by robot-ch-test-poll1
Loading

This is an automated comment for commit c10fc6d with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS⏳ pending
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Mergeable CheckChecks if all other necessary checks are successful⏳ pending
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success

@kssenii kssenii force-pushed the use-iobject-storage-for-table-engines-1 branch 3 times, most recently from 1fb6859 to ee6eb96 Compare February 9, 2024 18:15
@kssenii kssenii force-pushed the use-iobject-storage-for-table-engines-1 branch 2 times, most recently from 144f959 to 328824e Compare February 12, 2024 18:53
@kssenii kssenii force-pushed the use-iobject-storage-for-table-engines-1 branch 6 times, most recently from d3cb6dc to 4ee04ee Compare February 14, 2024 14:28
@kssenii kssenii force-pushed the use-iobject-storage-for-table-engines-1 branch from 4ee04ee to 84b0fe6 Compare February 14, 2024 14:50
@Avogar Avogar self-assigned this Feb 16, 2024
@kssenii kssenii force-pushed the use-iobject-storage-for-table-engines-1 branch from a947b5f to 0552f44 Compare February 19, 2024 15:44
@kssenii
Copy link
Copy Markdown
Member Author

kssenii commented May 25, 2024 •
edited
Loading

Stateless tests (coverage) [6/6] — fail: 1

02581_share_big_sets_between_multiple_mutations_tasks_long -- not related to changes

A Sync Pending

A sync is green, there is 1 stateless check run which is not green, but it is because of broken in master tests.

Upgrade check (debug)

I did add new settings to settings changes history, but it complains now because of the new release - they need to be moved to 24.6, but as the upgrade check now fails in master anyway because of several other such settings, I will fix it in the follow up PR (today). (Because this PR grows in conflicts too quickly, I do not want to wait for more conflicts any longer)

Update: #64398

@kssenii kssenii added this pull request to the merge queue May 25, 2024
Merged via the queue into master with commit 31fd4f5 May 25, 2024
@kssenii kssenii deleted the use-iobject-storage-for-table-engines-1 branch May 25, 2024 10:03
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label May 25, 2024
@kssenii kssenii mentioned this pull request May 25, 2024
Merged
32 tasks
baibaichen added a commit to Kyligence/gluten that referenced this pull request May 26, 2024
@baibaichen
Fix build due to ClickHouse/ClickHouse#59767
107e1a5
baibaichen added a commit to Kyligence/gluten that referenced this pull request May 26, 2024
@baibaichen
Fix build due to ClickHouse/ClickHouse#59767
d532094
github-merge-queue bot pushed a commit that referenced this pull request May 26, 2024
@kssenii
Merge pull request #64398 from ClickHouse/follow-up-to-59767
2c3c0d0 
Follow-up to #59767
baibaichen added a commit to apache/gluten that referenced this pull request May 26, 2024
@kyligence-git @baibaichen
[GLUTEN-1632][CH]Daily Update Clickhouse Version (20240526) (#5870)
56c5a24 
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240526)

* Fix build due to ClickHouse/ClickHouse#59767

---------

Co-authored-by: kyligence-git <[email protected]>
Co-authored-by: Chang Chen <[email protected]>
@kssenii kssenii mentioned this pull request May 26, 2024
Merged
29 tasks
alexey-milovidov added a commit that referenced this pull request May 27, 2024
@alexey-milovidov
Merge pull request #64404 from ClickHouse/fix-apply-new-settings
8d3f32b 
Follow up to #59767
@alesapin alesapin mentioned this pull request May 27, 2024
Merged
30 tasks
@divanik divanik mentioned this pull request May 31, 2024
Open
8 tasks
@SmitaRKulkarni SmitaRKulkarni mentioned this pull request Jun 28, 2024
Merged
yariks5s
yariks5s reviewed Oct 30, 2024
View reviewed changes
src/Disks/ObjectStorages/HDFS/HDFSObjectStorage.cpp
if (path.starts_with(url))
path = path.substr(url.size());
if (path.starts_with("/"))
path.substr(1);
Copy link
Copy Markdown
Member

@yariks5s yariks5s Oct 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this line be: path = path.substr(1);, as on the l. 50?

Upd: created a PR regarding it: #71267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yariks5s yariks5s yariks5s left review comments

@Avogar Avogar Avogar approved these changes

Assignees

@Avogar Avogar

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kssenii @robot-ch-test-poll4 @Avogar @yariks5s