Skip to content

Parse CRLF with TSV files#59747

Merged
Avogar merged 58 commits intoClickHouse:masterfrom
Blargian:56257_parse_crlf_with_TSV_files
May 22, 2024
Merged

Parse CRLF with TSV files#59747
Avogar merged 58 commits intoClickHouse:masterfrom
Blargian:56257_parse_crlf_with_TSV_files

Conversation

@Blargian
Copy link
Copy Markdown
Member

@Blargian Blargian commented Feb 8, 2024 •
edited by Avogar
Loading

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

User can now parse CRLF with TSV format using a setting input_format_tsv_crlf_end_of_line. Closes #56257.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Description of changes made

  • added boolean setting called input_format_tsv_crlf_end_of_line
  • added template parameter bool support_crlf to readEscapedStringInto and readEscapedStringIntoImpl as well as to readTSVField
  • Rather than modifying readEscapedString I added a new function readEscapedStringCRLF, the reasoning behind this being that readEscapedString is used in many other places in the code base.
  • Modified readEscapedStringIntoImpl to parse Fields correctly in the case that support_crlf is true.
  • Modified checkForCarriageReturn and skipRowEndDelimiter so that exceptions are not thrown with crlf

I used the attached data set for testing and used unix2dos data_small.tsv and dos2unix data_small.tsv to convert back and forth between line ending types to test
https://gist.github.com/Blargian/0e36a74519d9c52ed0d0fba13ce5fc78

@clickhouse-ci
Copy link
Copy Markdown

clickhouse-ci bot commented Feb 8, 2024

This is an automatic comment. The PR descriptions does not match the template.

Please, edit it accordingly.

The error is: Changelog category is empty

2 similar comments
@clickhouse-ci
Copy link
Copy Markdown

clickhouse-ci bot commented Feb 8, 2024

This is an automatic comment. The PR descriptions does not match the template.

Please, edit it accordingly.

The error is: Changelog category is empty

@clickhouse-ci
Copy link
Copy Markdown

clickhouse-ci bot commented Feb 8, 2024

This is an automatic comment. The PR descriptions does not match the template.

Please, edit it accordingly.

The error is: Changelog category is empty

@Blargian Blargian changed the title [draft] Parse CRLF with TSV files [WIP] Parse CRLF with TSV files Feb 8, 2024
@Avogar Avogar self-assigned this Feb 10, 2024
@Avogar
Copy link
Copy Markdown
Member

Avogar commented Feb 10, 2024

I will take a look when I am back from vacation next week

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-feature Pull request with new product feature label Feb 10, 2024
@robot-clickhouse-ci-2
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-2 commented Feb 10, 2024 •
edited
Loading

This is an automated comment for commit 4cfe266 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@Avogar Avogar added the can be tested Allows running workflows for external contributors label Feb 13, 2024
@Blargian
Copy link
Copy Markdown
Member Author

Blargian commented Feb 21, 2024

@Avogar is there a way to check what is causing the A Sync check to fail? I don't see any logs or further details on this one when I follow the link from the robot-clickhouse comment - link seems broken.

@Avogar
Copy link
Copy Markdown
Member

Avogar commented Feb 21, 2024

A Sync is a special internal check for developers, I will fix it, don't worry about it

@Blargian Blargian mentioned this pull request Mar 9, 2024
Closed
@Blargian Blargian changed the title [WIP] Parse CRLF with TSV files Parse CRLF with TSV files Apr 9, 2024
@Avogar Avogar added this pull request to the merge queue Apr 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 29, 2024
@Avogar Avogar added this pull request to the merge queue May 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 13, 2024
@Avogar Avogar added this pull request to the merge queue May 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 13, 2024
@Avogar
Copy link
Copy Markdown
Member

Avogar commented May 15, 2024 •
edited
Loading

I actually don't understand why build fails in file that wasn't changed in this PR...

Avogar
Avogar reviewed May 15, 2024
View reviewed changes
@Avogar Avogar added this pull request to the merge queue May 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 22, 2024
@Avogar Avogar added this pull request to the merge queue May 22, 2024
Merged via the queue into ClickHouse:master with commit fddedee May 22, 2024
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Avogar Avogar Avogar approved these changes

Assignees

@Avogar Avogar

Labels

can be tested Allows running workflows for external contributors pr-feature Pull request with new product feature pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a setting to parse crlf with Tab separated CSV (TSV?!) files

4 participants

@Blargian @Avogar @robot-clickhouse-ci-2 @robot-clickhouse