Analyzer: compute ALIAS columns right after reading by vdimir · Pull Request #59595 · ClickHouse/ClickHouse

vdimir · 2024-02-05T16:55:36Z

Changelog category (leave one):

Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

Documentation entry for user-facing changes

Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

robot-ch-test-poll1 · 2024-02-05T16:58:45Z

This is an automated comment for commit 973c253 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks

Check name	Description	Status
A Sync	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	✅ success
ClickBench	Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table	✅ success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker keeper image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docker server image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docs check	Builds and tests the documentation	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Mergeable Check	Checks if all other necessary checks are successful	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
SQLTest	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
SQLancer	Fuzzing tests that detect logical bugs with SQLancer tool	✅ success
Sqllogic	Run clickhouse on the sqllogic test set against sqlite and checks that all statements are passed	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

Check name	Description	Status
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	⏳ pending
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	❌ failure
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	❌ failure

novikd · 2024-02-06T11:20:53Z

I need this PR for #50894

vdimir · 2024-02-06T12:39:38Z

Integration tests (asan, analyzer) [2/6] — fail: 5, passed: 358 Details

fixing row policy ...
UPD: also doesn't work with PREWHERE and moveToPrewhere.

novikd · 2024-02-20T13:14:08Z

src/Storages/StorageDistributed.cpp

+        const auto & column_source = column_node->getColumnSourceOrNull();
+        if (column_source && (column_source->getNodeType() == QueryTreeNodeType::ARRAY_JOIN || column_source->getNodeType() == QueryTreeNodeType::JOIN))
+            return;
+        node = column_node->getExpression();


maybe it's a good idea to also save alias here?

Do you mean to set node->setAlias(column_node->getColumnName()) for replaced node? Added, let's see if it changes anything

src/Planner/TableExpressionData.h

src/Planner/CollectTableExpressionData.cpp

novikd · 2024-02-20T19:26:42Z

src/Planner/CollectTableExpressionData.cpp

+    /// Replace ALIAS columns with their expressions or register them in table expression data.
+    /// Usually we can replace them when we build some "local" actions DAG
+    /// (for example Row Policy or PREWHERE) that is applied on right top of table expression.
+    bool keep_alias_columns = true;


When can not we do it?

In other cases, when we keep ColumnNode with expression and compute after read. Added it to comment

novikd · 2024-02-20T19:31:12Z

Is it possible to remove alias columns computation in StorageMerge?

vdimir · 2024-02-21T11:23:01Z

Is it possible to remove alias columns computation in StorageMerge?

I'm afraid there's not straightforward way to remove it, because planning of reading from source tables for Merge is hidden inside read method. But for Planner it's a blackbox and we could compute alias columns if StorageMerge itself had them. So, planner is not aware about underlying ALIAS columns and we still have to keep code to handle them in StorageMerge

vdimir · 2024-02-26T12:02:19Z

Test failures @ cdd88c4 related to #60373

vdimir · 2024-02-29T09:28:28Z

Stress test (ubsan) — Killed by signal (in clickhouse-server.log) Details

#60538

Integration tests (asan, analyzer) [2/6] — fail: 4, passed: 373 Details

test_kafka_bad_messages #58321

test_passing_max_partitions_to_read_remotely/test.py::test_default_database_on_cluster:

E               ERROR: for schema-registry  Cannot start service schema-registry: driver failed programming external connectivity on endpoint roottestkafkabadmessages_schema-registry_1 (e06efdc64c628f5a985bd465ddf2e8a4deb10d73ae86fad450477ff5032eabfc): Bind for 0.0.0.0:53539 failed: port is already allocated

Integration tests (tsan) [2/6] — fail: 1, passed: 379 Details

#60539

filimonov · 2026-01-20T09:47:56Z

src/Planner/PlannerJoinTree.cpp

+                    ActionsDAGPtr merged_alias_columns_actions_dag = std::make_shared<ActionsDAG>(query_plan.getCurrentDataStream().header.getColumnsWithTypeAndName());
+                    ActionsDAG::NodeRawConstPtrs action_dag_outputs = merged_alias_columns_actions_dag->getInputs();
+
+                    for (const auto & [column_name, alias_column_actions_dag] : alias_column_expressions)


iteration over unordered map here. It makes the order of column in the resulting header unstable, and leads to columns swapping in the distributed queries.

Fixed in #94644

vdimir added the analyzer Issues and pull-requests related to new analyzer label Feb 5, 2024

robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Feb 5, 2024

novikd self-assigned this Feb 6, 2024

vdimir force-pushed the vdimir/analyzer/comute_alias_columns branch 2 times, most recently from 9383704 to fa7abfb Compare February 14, 2024 13:31

vdimir marked this pull request as ready for review February 14, 2024 13:41

vdimir force-pushed the vdimir/analyzer/comute_alias_columns branch 2 times, most recently from 7cfd7db to 8462f3a Compare February 14, 2024 17:10

vdimir requested a review from novikd February 15, 2024 14:12

vdimir mentioned this pull request Feb 20, 2024

Analyzer: support join using column from select list #60182

Merged

novikd reviewed Feb 20, 2024

View reviewed changes

vdimir force-pushed the vdimir/analyzer/comute_alias_columns branch from 8462f3a to e69aa4f Compare February 21, 2024 11:17

vdimir force-pushed the vdimir/analyzer/comute_alias_columns branch 2 times, most recently from 1075ef0 to cdd88c4 Compare February 23, 2024 16:24

vdimir force-pushed the vdimir/analyzer/comute_alias_columns branch from cdd88c4 to e67b0be Compare February 26, 2024 12:12

vdimir added 2 commits February 26, 2024 16:15

Analyzer: compute ALIAS columns right after reading

5a9026f

review fix

9f1a073

vdimir force-pushed the vdimir/analyzer/comute_alias_columns branch from e67b0be to 9f1a073 Compare February 26, 2024 16:15

fix 02911_support_alias_column_in_indices

973c253

vdimir merged commit 5dd81f3 into master Feb 29, 2024

vdimir deleted the vdimir/analyzer/comute_alias_columns branch February 29, 2024 09:28

robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Feb 29, 2024

tavplubix mentioned this pull request Feb 29, 2024

Revert "Analyzer: compute ALIAS columns right after reading" #60570

Merged

vdimir restored the vdimir/analyzer/comute_alias_columns branch March 1, 2024 12:03

filimonov reviewed Jan 20, 2026

View reviewed changes

Conversation

vdimir commented Feb 5, 2024

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Documentation entry for user-facing changes

Uh oh!

robot-ch-test-poll1 commented Feb 5, 2024 • edited by robot-ch-test-poll2 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

novikd commented Feb 6, 2024

Uh oh!

vdimir commented Feb 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

novikd Feb 20, 2024

Choose a reason for hiding this comment

Uh oh!

vdimir Feb 21, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

novikd Feb 20, 2024

Choose a reason for hiding this comment

Uh oh!

vdimir Feb 21, 2024

Choose a reason for hiding this comment

Uh oh!

novikd commented Feb 20, 2024

Uh oh!

vdimir commented Feb 21, 2024

Uh oh!

vdimir commented Feb 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vdimir commented Feb 29, 2024

Uh oh!

filimonov Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

robot-ch-test-poll1 commented Feb 5, 2024 •

edited by robot-ch-test-poll2

Loading

vdimir commented Feb 6, 2024 •

edited

Loading

vdimir commented Feb 26, 2024 •

edited

Loading