Skip to content

Bump libssh to 0.9.8#59563

Merged
rschu1ze merged 5 commits intoClickHouse:masterfrom
rschu1ze:libssh-0.9.8
Feb 15, 2024
Merged

Bump libssh to 0.9.8#59563
rschu1ze merged 5 commits intoClickHouse:masterfrom
rschu1ze:libssh-0.9.8

Conversation

@rschu1ze
Copy link
Copy Markdown
Member

@rschu1ze rschu1ze commented Feb 5, 2024 •
edited
Loading

This PR does three things:

  1. I undoes some terrible silent patching caused in the submodule (also see Apply random patches from some unknown source libssh#9): ae7dcdf

  2. it upgrades libssh from v0.9.7 to v0.9.8: e3896a3

  3. Does some cleanup in the build description for the libssh submodule a740fc7

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@rschu1ze rschu1ze marked this pull request as ready for review February 5, 2024 09:15
@robot-ch-test-poll3 robot-ch-test-poll3 added pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR. labels Feb 5, 2024
@robot-ch-test-poll3
Copy link
Copy Markdown
Contributor

robot-ch-test-poll3 commented Feb 5, 2024 •
edited by robot-clickhouse
Loading

This is an automated comment for commit ea89154 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS❌ failure
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
SQLancerFuzzing tests that detect logical bugs with SQLancer tool❌ failure
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure

@rschu1ze rschu1ze mentioned this pull request Feb 5, 2024
Merged
@rschu1ze

This comment was marked as outdated.

Sign in to view
@antaljanosbenjamin antaljanosbenjamin self-assigned this Feb 5, 2024
@antaljanosbenjamin
Copy link
Copy Markdown
Member

antaljanosbenjamin commented Feb 7, 2024

Just posting here for visibility. I left a comment on the original PR on Robert's comment:

Based on config.h.cmake and this command you have to generate them by configuring libssh using the built in cmake.

@rschu1ze
Copy link
Copy Markdown
Member Author

rschu1ze commented Feb 7, 2024

Thanks @antaljanosbenjamin ... I updated the PR and combined it with some cleanup.

@rschu1ze
Copy link
Copy Markdown
Member Author

rschu1ze commented Feb 15, 2024

ClickHouse AST Fuzzer (msan): Unrelated, opened #60017

SQLLancer (release): looking at the output (here and here), it is not clear to me what went wrong but it is surely unrelated.

Stress test and upgrade check: unrelated as well.

@rschu1ze rschu1ze merged commit 973e178 into ClickHouse:master Feb 15, 2024
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antaljanosbenjamin antaljanosbenjamin antaljanosbenjamin approved these changes

Assignees

@antaljanosbenjamin antaljanosbenjamin

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo submodule changed At least one submodule changed in this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rschu1ze @robot-ch-test-poll3 @antaljanosbenjamin @robot-clickhouse-ci-1