Skip to content

Add sanity checks for function return types#59379

Merged
Algunenano merged 1 commit intoClickHouse:masterfrom
Algunenano:fix_translate_asserts
Jan 31, 2024
Merged

Add sanity checks for function return types#59379
Algunenano merged 1 commit intoClickHouse:masterfrom
Algunenano:fix_translate_asserts

Conversation

@Algunenano
Copy link
Copy Markdown
Member

@Algunenano Algunenano commented Jan 30, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

Documentation entry for user-facing changes

Followup for #59356

Let's add some checks that function return the type they said they were going to return. It should help the fuzzer detect problems as it will trigger the assert/exception even if an empty column is returned.

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jan 30, 2024
@robot-ch-test-poll1
Copy link
Copy Markdown
Contributor

robot-ch-test-poll1 commented Jan 30, 2024 •
edited
Loading

This is an automated comment for commit f79a402 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker server and keeper imagesThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Docs checkThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Fast testsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure

@jsc0218 jsc0218 self-assigned this Jan 30, 2024
@Algunenano
Copy link
Copy Markdown
Member Author

Algunenano commented Jan 31, 2024

Failures:

@Algunenano Algunenano merged commit f875151 into ClickHouse:master Jan 31, 2024
This was referenced Jan 31, 2024
Merged
Merged
@antonio2368 antonio2368 mentioned this pull request Mar 8, 2024
Closed
@tavplubix
Copy link
Copy Markdown
Member

tavplubix commented May 3, 2024

@Algunenano FYI Unexpected return type errors in the CI: https://play.clickhouse.com/play?user=play#CldJVEgKICAgICcnIEFTIG5hbWVfc3Vic3RyLAogICAgMzY1IEFTIGludGVydmFsX2RheXMsCiAgICAoJ1N0YXRlbGVzcyB0ZXN0cyAoYXNhbiknLCAnU3RhdGVsZXNzIHRlc3RzIChhZGRyZXNzKScsICdTdGF0ZWxlc3MgdGVzdHMgKGFkZHJlc3MsIGFjdGlvbnMpJykgQVMgYmFja3BvcnRfYW5kX3JlbGVhc2Vfc3BlY2lmaWNfY2hlY2tzClNFTEVDVAogICAgdG9TdGFydE9mRGF5KGNoZWNrX3N0YXJ0X3RpbWUpIEFTIGQsCiAgICBjb3VudCgpLAogICAgZ3JvdXBVbmlxQXJyYXkocHVsbF9yZXF1ZXN0X251bWJlcikgQVMgcHJzLAogICAgYW55KHJlcG9ydF91cmwpCkZST00gY2hlY2tzCldIRVJFICgobm93KCkgLSB0b0ludGVydmFsRGF5KGludGVydmFsX2RheXMpKSA8PSBjaGVja19zdGFydF90aW1lKSBBTkQgKHB1bGxfcmVxdWVzdF9udW1iZXIgTk9UIElOICgKICAgIFNFTEVDVCBwdWxsX3JlcXVlc3RfbnVtYmVyIEFTIHBybgogICAgRlJPTSBjaGVja3MKICAgIFdIRVJFIChwcm4gIT0gMCkgQU5EICgobm93KCkgLSB0b0ludGVydmFsRGF5KGludGVydmFsX2RheXMpKSA8PSBjaGVja19zdGFydF90aW1lKSBBTkQgKGNoZWNrX25hbWUgSU4gKGJhY2twb3J0X2FuZF9yZWxlYXNlX3NwZWNpZmljX2NoZWNrcykpCikpIEFORCAocG9zaXRpb24odGVzdF9uYW1lLCBuYW1lX3N1YnN0cikgPiAwKSBBTkQgKHRlc3Rfc3RhdHVzIElOICgnRkFJTCcsICdFUlJPUicsICdGTEFLWScpKQpBTkQgdGVzdF9jb250ZXh0X3JhdyBsaWtlICclVW5leHBlY3RlZCByZXR1cm4gdHlwZSBmcm9tICUnCkdST1VQIEJZIGQKT1JERVIgQlkgZCBERVNDCg==

@Algunenano
Copy link
Copy Markdown
Member Author

Algunenano commented May 3, 2024

@Algunenano FYI Unexpected return type errors in the CI

We've fixed many issues detected by these checks, specially by the fuzzer. The problem is that each one has to be reported and investigated individually. In the the query I see quite a few related to EXPLAIN PIPELINE so it's possible that it's finding the same issue over and over

@Algunenano
Copy link
Copy Markdown
Member Author

Algunenano commented May 3, 2024

For the sake of completeness, I've investigated one of the reports randomly and it's detecting multiple issues, both in the old and the new analyzer -> #63349

@alesapin alesapin mentioned this pull request May 3, 2024
Merged
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jsc0218 jsc0218 jsc0218 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jsc0218 jsc0218

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Algunenano @robot-ch-test-poll1 @tavplubix @jsc0218