Skip to content

Re-apply MySQL net write/read settings changeset#59293

Merged
alexey-milovidov merged 5 commits into
ClickHouse:masterfrom
slvrtrn:reapply-net-read-write-mysql
Jan 30, 2024
Merged

Re-apply MySQL net write/read settings changeset#59293
alexey-milovidov merged 5 commits into
ClickHouse:masterfrom
slvrtrn:reapply-net-read-write-mysql

Conversation

@slvrtrn

@slvrtrn slvrtrn commented Jan 27, 2024

Copy link
Copy Markdown
Contributor

Re-apply changeset from (PR) #58835, which was reverted in (PR) #58872 due to (issue) #58918.

Since the issue is primarily "cosmetic" (wrong limit value in system.settings, but it's actually applied) and (PR) #59018 is still a draft, I rewrote an offending test, so it is not blocking and maybe we can still include it in 24.1.


Original description from (PR) #58835:

Resolves #58553

Allows to use the following settings via MySQL interface:

SET NET_WRITE_TIMEOUT = X;
SET NET_READ_TIMEOUT = Y;

net_write_timeout is translated into the native send_timeout ClickHouse setting and, similarly, net_read_timeout into receive_timeout. These statements work regardless of the input query being upper or lower case.

Additionally, fixed an issue where changing MySQL SQL_SELECT_LIMIT setting was possible only if the entire statement was in upper case.

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

MySQL interface gained support for net_write_timeout and net_read_timeout settings. net_write_timeout is translated into the native send_timeout ClickHouse setting and, similarly, net_read_timeout into receive_timeout. Fixed an issue where it was possible to set MySQL sql_select_limit setting only if the entire statement was in upper case.

@slvrtrn slvrtrn added pr-improvement Pull request with some product improvements can be tested Allows running workflows for external contributors labels Jan 27, 2024
@slvrtrn
slvrtrn requested a review from rschu1ze January 27, 2024 17:48
@robot-ch-test-poll1

robot-ch-test-poll1 commented Jan 27, 2024

Copy link
Copy Markdown
Contributor

This is an automated comment for commit 5192d38 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker server and keeper imagesThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Docs checkThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Fast testsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Unit testsRuns the unit tests for different release types✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure

Comment thread src/Server/MySQLHandler.cpp Outdated
Comment thread src/Server/MySQLHandler.cpp Outdated
Comment thread src/Server/MySQLHandler.cpp Outdated
Comment thread tests/queries/0_stateless/02967_mysql_settings_override.sh Outdated
Comment thread tests/queries/0_stateless/02967_mysql_settings_override.sh Outdated
Comment thread tests/queries/0_stateless/02967_mysql_settings_override.sh Outdated
Comment thread src/Server/MySQLHandler.h
Comment thread src/Server/MySQLHandler.cpp Outdated
@slvrtrn

slvrtrn commented Jan 29, 2024

Copy link
Copy Markdown
Contributor Author

@rschu1ze, I addressed the review comments. Can you please have a look one more time?

@alexey-milovidov
alexey-milovidov merged commit 5cf1242 into ClickHouse:master Jan 30, 2024
@alexey-milovidov alexey-milovidov self-assigned this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

can be tested Allows running workflows for external contributors pr-improvement Pull request with some product improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MySQL compatibility: SET net_write_timeout

4 participants