Re-apply MySQL net write/read settings changeset#59293
Merged
alexey-milovidov merged 5 commits intoJan 30, 2024
Merged
Conversation
Contributor
|
This is an automated comment for commit 5192d38 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
rschu1ze
reviewed
Jan 27, 2024
Contributor
Author
|
@rschu1ze, I addressed the review comments. Can you please have a look one more time? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-apply changeset from (PR) #58835, which was reverted in (PR) #58872 due to (issue) #58918.
Since the issue is primarily "cosmetic" (wrong
limitvalue insystem.settings, but it's actually applied) and (PR) #59018 is still a draft, I rewrote an offending test, so it is not blocking and maybe we can still include it in 24.1.Original description from (PR) #58835:
Resolves #58553
Allows to use the following settings via MySQL interface:
net_write_timeoutis translated into the nativesend_timeoutClickHouse setting and, similarly,net_read_timeoutintoreceive_timeout. These statements work regardless of the input query being upper or lower case.Additionally, fixed an issue where changing MySQL
SQL_SELECT_LIMITsetting was possible only if the entire statement was in upper case.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
MySQL interface gained support for
net_write_timeoutandnet_read_timeoutsettings.net_write_timeoutis translated into the nativesend_timeoutClickHouse setting and, similarly,net_read_timeoutintoreceive_timeout. Fixed an issue where it was possible to set MySQLsql_select_limitsetting only if the entire statement was in upper case.