Skip to content

Support specifying settings for Distributed engine in config (like for MergeTree)#59291

Merged
rschu1ze merged 5 commits intoClickHouse:masterfrom
azat:dist/config-settings
Feb 27, 2024
Merged

Support specifying settings for Distributed engine in config (like for MergeTree)#59291
rschu1ze merged 5 commits intoClickHouse:masterfrom
azat:dist/config-settings

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Jan 27, 2024 •
edited by rschu1ze
Loading

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Settings for the Distributed table engine can now be specified in the server configuration file (similar to MergeTree settings), e.g.

<distributed>
    <flush_on_detach>false</flush_on_detach>
</distributed>

Settings for Distributed tables specified in CREATE TABLE, e.g. CREATE TABLE ... (...) ENGINE = Distributed(...) SETTINGS flush_on_detach = true take precedence over settings defined in the server configuration file.

@azat azat mentioned this pull request Jan 27, 2024
Merged
@azat azat changed the title Add example of configuring ReplicatedMergeTree via config.xml Support specifying settings for Distributed engine in config (like for MergeTree) Jan 27, 2024
@robot-ch-test-poll robot-ch-test-poll added the pr-improvement Pull request with some product improvements label Jan 27, 2024
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented Jan 27, 2024 •
edited by robot-ch-test-poll2
Loading

This is an automated comment for commit 4794dc2 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure

@azat

This comment was marked as outdated.

Sign in to view
@azat

This comment was marked as outdated.

Sign in to view
@azat

This comment was marked as outdated.

Sign in to view
@rschu1ze rschu1ze self-assigned this Feb 21, 2024
rschu1ze
rschu1ze reviewed Feb 26, 2024
View reviewed changes
rschu1ze
rschu1ze approved these changes Feb 26, 2024
View reviewed changes
@rschu1ze rschu1ze merged commit 0f6bec7 into ClickHouse:master Feb 27, 2024
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Feb 27, 2024
@azat azat deleted the dist/config-settings branch February 27, 2024 16:44
Avogar
Avogar reviewed Mar 13, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Avogar Avogar Avogar left review comments

@rschu1ze rschu1ze rschu1ze approved these changes

Assignees

@rschu1ze rschu1ze

Labels

pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@azat @robot-ch-test-poll @Avogar @rschu1ze @robot-ch-test-poll1